Fix TouchExplorationInCrossSiteIframe flakiness with OOPIFs enabled

Fix TouchExplorationInCrossSiteIframe flakiness with OOPIFs enabled

TouchAccessibilityBrowserTest.TouchExplorationInCrossSiteIframe sends
a touch event to a cross-origin iframe. When OOPIFs are enabled, this
relies on the browser hit testing path for the event to reach the
correct RenderWidgetHostView. There is currently flakiness because
sometimes the browser process has not received enough compositor frames
for that hit testing to work.

This patch uses SurfaceHitTestReadyNotifier to delay the event until
hit testing will succeed.

BUG=706163
Review-Url: https://codereview.chromium.org/2785793002
Cr-Commit-Position: refs/heads/master@{#460551}
Committed: https://chromium.googlesource.com/chromium/src/+/37401561f9eaf8e8921e3ac4680067dc19ad5d54

[kenrb, 2017-03-29 20:08:53]

The CQ bit was checked by kenrb@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-29 20:09:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kenrb, 2017-03-29 20:19:56]

kenrb@chromium.org changed reviewers:
+ dmazzoni@chromium.org

[kenrb, 2017-03-29 20:19:57]

dmazzoni@: PTAL?

I recently removed renderer-to-renderer input forwarding for OOPIFs
(https://codereview.chromium.org/2723963003/), which was a temporary fallback
path that would allow some input events to work even if browser process hit
testing failed for some reason. That removal caused this test to become flaky,
for reasons given in the description.

[commit-bot: I haz the power, 2017-03-29 21:11:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-29 21:11:56]

Dry run: This issue passed the CQ dry run.

[dmazzoni, 2017-03-29 21:16:09]

lgtm

Thanks for the fix!

I wonder if this should be done automatically
in test helper code, like in NavigateToURL, or
when SetupCrossSiteRedirector is called, or
something like that.

[kenrb, 2017-03-29 22:11:08]

Thanks for the review.

I'm aware that the current state is a bit awkward, and that's a good suggestion,
adding it to the navigation code. I'll investigate options there.

[kenrb, 2017-03-29 22:11:12]

The CQ bit was checked by kenrb@chromium.org

[commit-bot: I haz the power, 2017-03-29 22:12:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-29 22:18:54]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1490825472983500, "parent_rev":
"888a70ed4f6e77b4019e24978a34cfbd2698acad", "commit_rev":
"37401561f9eaf8e8921e3ac4680067dc19ad5d54"}

[commit-bot: I haz the power, 2017-03-29 22:19:53]

Description was changed from

==========
Fix TouchExplorationInCrossSiteIframe flakiness with OOPIFs enabled

TouchAccessibilityBrowserTest.TouchExplorationInCrossSiteIframe sends
a touch event to a cross-origin iframe. When OOPIFs are enabled, this
relies on the browser hit testing path for the event to reach the
correct RenderWidgetHostView. There is currently flakiness because
sometimes the browser process has not received enough compositor frames
for that hit testing to work.

This patch uses SurfaceHitTestReadyNotifier to delay the event until
hit testing will succeed.

BUG=706163
==========

to

==========
Fix TouchExplorationInCrossSiteIframe flakiness with OOPIFs enabled

TouchAccessibilityBrowserTest.TouchExplorationInCrossSiteIframe sends
a touch event to a cross-origin iframe. When OOPIFs are enabled, this
relies on the browser hit testing path for the event to reach the
correct RenderWidgetHostView. There is currently flakiness because
sometimes the browser process has not received enough compositor frames
for that hit testing to work.

This patch uses SurfaceHitTestReadyNotifier to delay the event until
hit testing will succeed.

BUG=706163

Review-Url: https://codereview.chromium.org/2785793002
Cr-Commit-Position: refs/heads/master@{#460551}
Committed:
https://chromium.googlesource.com/chromium/src/+/37401561f9eaf8e8921e3ac46800...
==========

[commit-bot: I haz the power, 2017-03-29 22:19:54]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/37401561f9eaf8e8921e3ac46800...