Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Unified Diff: chrome/browser/ui/webui/signin/login_ui_test_utils.cc

Issue 2785753003: Exclude building signin view controller and its delegate on ChromeOS (Closed)
Patch Set: Exclude SigninViewController on ChromeOS Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/signin/login_ui_test_utils.cc
diff --git a/chrome/browser/ui/webui/signin/login_ui_test_utils.cc b/chrome/browser/ui/webui/signin/login_ui_test_utils.cc
index bece0d3d20aa71eaaef19cdd57258cd47233eb26..06fe6ac739b9ca5c8612468e62a991030d7920ac 100644
--- a/chrome/browser/ui/webui/signin/login_ui_test_utils.cc
+++ b/chrome/browser/ui/webui/signin/login_ui_test_utils.cc
@@ -253,6 +253,10 @@ bool SignInWithUI(Browser* browser,
}
bool TryDismissSyncConfirmationDialog(Browser* browser) {
+#if defined(OS_CHROMEOS)
+ NOTREACHED();
+ return false;
+#else
SigninViewController* signin_view_controller =
browser->signin_view_controller();
DCHECK_NE(signin_view_controller, nullptr);
@@ -273,6 +277,7 @@ bool TryDismissSyncConfirmationDialog(Browser* browser) {
EXPECT_TRUE(content::ExecuteScriptAndExtractString(dialog_web_contents, js,
&message));
return message == "Ok";
+#endif
}
bool DismissSyncConfirmationDialog(Browser* browser, base::TimeDelta timeout) {
« no previous file with comments | « chrome/browser/ui/webui/signin/login_ui_service.cc ('k') | chrome/browser/ui/webui/signin/signin_error_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698