Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1515)

Unified Diff: chrome/browser/ui/webui/signin/login_ui_service.cc

Issue 2785753003: Exclude building signin view controller and its delegate on ChromeOS (Closed)
Patch Set: Exclude SigninViewController on ChromeOS Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/signin/login_ui_service.cc
diff --git a/chrome/browser/ui/webui/signin/login_ui_service.cc b/chrome/browser/ui/webui/signin/login_ui_service.cc
index c54cdc99d5d9490ca206a406eea0f809a0d31305..a48468537b87e30ec9ffe6d0eba55d84b44d2bd7 100644
--- a/chrome/browser/ui/webui/signin/login_ui_service.cc
+++ b/chrome/browser/ui/webui/signin/login_ui_service.cc
@@ -70,12 +70,12 @@ void LoginUIService::DisplayLoginResult(Browser* browser,
#if defined(OS_CHROMEOS)
// ChromeOS doesn't have the avatar bubble so it never calls this function.
NOTREACHED();
-#endif
+#else
last_login_result_ = error_message;
last_login_error_email_ = email;
if (!error_message.empty()) {
if (browser)
- browser->ShowModalSigninErrorWindow();
+ browser->signin_view_controller()->ShowModalSigninErrorDialog(browser);
else
UserManagerProfileDialog::DisplayErrorMessage();
} else if (browser) {
@@ -85,6 +85,7 @@ void LoginUIService::DisplayLoginResult(Browser* browser,
signin::ManageAccountsParams(),
signin_metrics::AccessPoint::ACCESS_POINT_EXTENSIONS, false);
}
+#endif
}
const base::string16& LoginUIService::GetLastLoginResult() const {
« no previous file with comments | « chrome/browser/ui/webui/signin/inline_login_handler_impl.cc ('k') | chrome/browser/ui/webui/signin/login_ui_test_utils.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698