Aura-Mus: Plumb LocalSurfaceId to ui::Compositor

Aura-Mus: Plumb LocalSurfaceId to ui::Compositor

If the bounds of a WindowTreeHost changes and the cc::LocalSurfaceId provided
is valid, then plumb that cc::LocalSurfaceId to the ui::Compositor to be used
to generate the next CompositorFrame.

BUG=672962
Review-Url: https://codereview.chromium.org/2785703002
Cr-Commit-Position: refs/heads/master@{#460428}
Committed: https://chromium.googlesource.com/chromium/src/+/e23ed57fd39feb3c45e2719ce2723e05259ea81c

[Fady Samuel, 2017-03-29 12:06:41]

fsamuel@chromium.org changed reviewers:
+ danakj@chromium.org, sadrul@chromium.org

[Fady Samuel, 2017-03-29 12:06:41]

+sadrul@ for ui/aura/mus
+danakj@ for DEPS on cc/base/switches.h

[sadrul, 2017-03-29 15:06:15]

lgtm

https://codereview.chromium.org/2785703002/diff/1/ui/aura/mus/DEPS
File ui/aura/mus/DEPS (right):

https://codereview.chromium.org/2785703002/diff/1/ui/aura/mus/DEPS#newcode11
ui/aura/mus/DEPS:11: "+cc/surfaces/surface_reference_factory.h",
Should we instead DEPS all of cc, and exclude things we feel aura shouldn't muck
with (e.g. maybe cc/layers, cc/tree etc.)? Or allow whole subdirectories (e.g.
cc/base, cc/ipc, cc/surfaces etc.)

Would that be easier?

[Fady Samuel, 2017-03-29 15:08:06]

https://codereview.chromium.org/2785703002/diff/1/ui/aura/mus/DEPS
File ui/aura/mus/DEPS (right):

https://codereview.chromium.org/2785703002/diff/1/ui/aura/mus/DEPS#newcode11
ui/aura/mus/DEPS:11: "+cc/surfaces/surface_reference_factory.h",
On 2017/03/29 15:06:15, sadrul wrote:
> Should we instead DEPS all of cc, and exclude things we feel aura shouldn't
muck
> with (e.g. maybe cc/layers, cc/tree etc.)? Or allow whole subdirectories (e.g.
> cc/base, cc/ipc, cc/surfaces etc.)
> 
> Would that be easier?

Until we know/define what the cc public API is exactly, I'd rather include
things here file by file.

[Fady Samuel, 2017-03-29 15:15:19]

PTAL Dana for DEPS

[Fady Samuel, 2017-03-29 15:15:20]

PTAL Dana for DEPS

[danakj, 2017-03-29 15:23:17]

Looks like this switch doesn't belong in cc TBH. Where do switches that change
behaviour in aura mus go?

[Fady Samuel, 2017-03-29 15:24:42]

On 2017/03/29 15:23:17, danakj wrote:
> Looks like this switch doesn't belong in cc TBH. Where do switches that change
> behaviour in aura mus go?

This flag is used in cc too...

[Fady Samuel, 2017-03-29 15:31:47]

On 2017/03/29 15:24:42, Fady Samuel wrote:
> On 2017/03/29 15:23:17, danakj wrote:
> > Looks like this switch doesn't belong in cc TBH. Where do switches that
change
> > behaviour in aura mus go?
> 
> This flag is used in cc too...

Sorry I take that back. It's used in content and ui to set a setting to cc..

[danakj, 2017-03-29 15:42:25]

LGTM

[Fady Samuel, 2017-03-29 15:47:33]

The CQ bit was checked by fsamuel@chromium.org

[Fady Samuel, 2017-03-29 15:47:33]

The CQ bit was unchecked by fsamuel@chromium.org

[Fady Samuel, 2017-03-29 15:47:35]

The CQ bit was checked by fsamuel@chromium.org

[commit-bot: I haz the power, 2017-03-29 15:48:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-29 17:08:00]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1490802455450070, "parent_rev":
"66e6ebd323a1096fe1fe95f1db6e55d3648c4d43", "commit_rev":
"e23ed57fd39feb3c45e2719ce2723e05259ea81c"}

[commit-bot: I haz the power, 2017-03-29 17:08:47]

Description was changed from

==========
Aura-Mus: Plumb LocalSurfaceId to ui::Compositor

If the bounds of a WindowTreeHost changes and the cc::LocalSurfaceId provided
is valid, then plumb that cc::LocalSurfaceId to the ui::Compositor to be used
to generate the next CompositorFrame.

BUG=672962
==========

to

==========
Aura-Mus: Plumb LocalSurfaceId to ui::Compositor

If the bounds of a WindowTreeHost changes and the cc::LocalSurfaceId provided
is valid, then plumb that cc::LocalSurfaceId to the ui::Compositor to be used
to generate the next CompositorFrame.

BUG=672962

Review-Url: https://codereview.chromium.org/2785703002
Cr-Commit-Position: refs/heads/master@{#460428}
Committed:
https://chromium.googlesource.com/chromium/src/+/e23ed57fd39feb3c45e2719ce272...
==========

[commit-bot: I haz the power, 2017-03-29 17:08:48]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e23ed57fd39feb3c45e2719ce272...