ui/views/bubble/info_bubble.cc - Issue 2785683003: views: implement width snapping for DialogDelegateViews

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/bubble/info_bubble.cc

Issue 2785683003: views: implement width snapping for DialogDelegateViews (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/views/bubble/info_bubble.cc

diff --git a/ui/views/bubble/info_bubble.cc b/ui/views/bubble/info_bubble.cc

index 0b633c919269133c1d5b3c1c278c1731edc027e8..b996f60b3a86dd724e1f2e17106cea0e9f2f8097 100644

--- a/ui/views/bubble/info_bubble.cc

+++ b/ui/views/bubble/info_bubble.cc

@@ -86,7 +86,7 @@ NonClientFrameView* InfoBubble::CreateNonClientFrameView(Widget* widget) {

return frame_;

}

-gfx::Size InfoBubble::GetPreferredSize() const {

+gfx::Size InfoBubble::GetUnsnappedPreferredSize() const {

if (preferred_width_ == 0)

return BubbleDialogDelegateView::GetPreferredSize();

Peter Kasting 2017/03/30 00:35:36 I think this causes an infinite loop. Has to be V