views: implement width snapping for DialogDelegateViews

ui/views/bubble/info_bubble.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/bubble/info_bubble.h"
 
 #include "ui/gfx/geometry/point.h"
 #include "ui/gfx/geometry/rect.h"
 #include "ui/gfx/geometry/size.h"
 #include "ui/views/bubble/bubble_border.h"
@@ skipping 68 matching lines @@
 
 NonClientFrameView* InfoBubble::CreateNonClientFrameView(Widget* widget) {
   DCHECK(!frame_);
   frame_ = new InfoBubbleFrame(margins());
   frame_->set_available_bounds(anchor_widget()->GetWindowBoundsInScreen());
   frame_->SetBubbleBorder(std::unique_ptr<BubbleBorder>(
       new BubbleBorder(arrow(), shadow(), color())));
   return frame_;
 }
 
-gfx::Size InfoBubble::GetPreferredSize() const {
+gfx::Size InfoBubble::GetUnsnappedPreferredSize() const {
   if (preferred_width_ == 0)
     return BubbleDialogDelegateView::GetPreferredSize();

[Peter Kasting, 2017/03/30 00:35:36]

I think this causes an infinite loop.  Has to be View::GetPreferredSize(), I
believe?

 
   int pref_width = preferred_width_;
   pref_width -= frame_->GetInsets().width();
   pref_width -= 2 * kBubbleBorderVisibleWidth;
   return gfx::Size(pref_width, GetHeightForWidth(pref_width));
 }
 
 void InfoBubble::OnWidgetDestroyed(Widget* widget) {
   if (widget == widget_)
     widget_ = nullptr;
@@ skipping 18 matching lines @@
     SizeToContents();
     widget_->SetVisibilityChangedAnimationsEnabled(true);
     widget_->ShowInactive();
   } else {
     widget_->SetVisibilityChangedAnimationsEnabled(false);
     widget_->Hide();
   }
 }
 
 }  // namespace views