views: implement width snapping for DialogDelegateViews

chrome/browser/ui/views/permission_bubble/permission_prompt_impl.cc

Index: chrome/browser/ui/views/permission_bubble/permission_prompt_impl.cc
diff --git a/chrome/browser/ui/views/permission_bubble/permission_prompt_impl.cc b/chrome/browser/ui/views/permission_bubble/permission_prompt_impl.cc
index f85441092ccba6ffa8115b7fb4efe43793bd6c28..6fd622d64a4d3d48a96037ede085745161cf9227 100644
--- a/chrome/browser/ui/views/permission_bubble/permission_prompt_impl.cc
+++ b/chrome/browser/ui/views/permission_bubble/permission_prompt_impl.cc
@@ -152,12 +152,14 @@ class PermissionsBubbleDialogDelegateView
   void CloseBubble();
   void SizeToContents();
 
+  // DialogDelegateView:
+  gfx::Size GetUnsnappedPreferredSize() const override;

[Peter Kasting, 2017/03/30 00:35:35]

Nit: Leave as part of the below list

+
   // BubbleDialogDelegateView:
   bool ShouldShowCloseButton() const override;
   const gfx::FontList& GetTitleFontList() const override;
   base::string16 GetWindowTitle() const override;
   void OnWidgetDestroying(views::Widget* widget) override;
-  gfx::Size GetPreferredSize() const override;
   void GetAccessibleNodeData(ui::AXNodeData* node_data) override;
   bool Cancel() override;
   bool Accept() override;
@@ -306,7 +308,8 @@ void PermissionsBubbleDialogDelegateView::OnWidgetDestroying(
   }
 }
 
-gfx::Size PermissionsBubbleDialogDelegateView::GetPreferredSize() const {
+gfx::Size PermissionsBubbleDialogDelegateView::GetUnsnappedPreferredSize()
+    const {
   // TODO(estade): bubbles should default to this width.

[Peter Kasting, 2017/03/30 00:35:35]

Nit: This TODO can go away.  In fact I think this whole override can maybe go
away.

   const int kWidth = 320 - GetInsets().width();

[Peter Kasting, 2017/03/30 00:35:35]

I don't understand why this wants to subtract GetInsets().  Are the insets going
to be outdented on the preferred size when computing the final visible size?  If
so that's kind of lame, because that means we need to subtract off the insets in
DialogDelegateView after computing the snapped width.  But I'm hoping this is
just wrong.

   return gfx::Size(kWidth, GetHeightForWidth(kWidth));