views: implement width snapping for DialogDelegateViews

chrome/browser/ui/views/permission_bubble/permission_prompt_impl.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/permission_bubble/permission_prompt_impl.h"
 
 #include <stddef.h>
 
 #include "base/macros.h"
 #include "base/memory/ptr_util.h"
@@ skipping 134 matching lines @@
  public:
   PermissionsBubbleDialogDelegateView(
       PermissionPromptImpl* owner,
       const std::vector<PermissionRequest*>& requests,
       const std::vector<bool>& accept_state);
   ~PermissionsBubbleDialogDelegateView() override;
 
   void CloseBubble();
   void SizeToContents();
 
+  // DialogDelegateView:
+  gfx::Size GetUnsnappedPreferredSize() const override;

[Peter Kasting, 2017/03/30 00:35:35]

Nit: Leave as part of the below list

+
   // BubbleDialogDelegateView:
   bool ShouldShowCloseButton() const override;
   const gfx::FontList& GetTitleFontList() const override;
   base::string16 GetWindowTitle() const override;
   void OnWidgetDestroying(views::Widget* widget) override;
-  gfx::Size GetPreferredSize() const override;
   void GetAccessibleNodeData(ui::AXNodeData* node_data) override;
   bool Cancel() override;
   bool Accept() override;
   bool Close() override;
   int GetDefaultDialogButton() const override;
   int GetDialogButtons() const override;
   base::string16 GetDialogButtonLabel(ui::DialogButton button) const override;
 
   // PermissionCombobox::Listener:
   void PermissionSelectionChanged(int index, bool allowed) override;
@@ skipping 128 matching lines @@
 
 void PermissionsBubbleDialogDelegateView::OnWidgetDestroying(
     views::Widget* widget) {
   views::BubbleDialogDelegateView::OnWidgetDestroying(widget);
   if (owner_) {
     owner_->Closing();
     owner_ = nullptr;
   }
 }
 
-gfx::Size PermissionsBubbleDialogDelegateView::GetPreferredSize() const {
+gfx::Size PermissionsBubbleDialogDelegateView::GetUnsnappedPreferredSize()
+    const {
   // TODO(estade): bubbles should default to this width.

[Peter Kasting, 2017/03/30 00:35:35]

Nit: This TODO can go away.  In fact I think this whole override can maybe go
away.

   const int kWidth = 320 - GetInsets().width();

[Peter Kasting, 2017/03/30 00:35:35]

I don't understand why this wants to subtract GetInsets().  Are the insets going
to be outdented on the preferred size when computing the final visible size?  If
so that's kind of lame, because that means we need to subtract off the insets in
DialogDelegateView after computing the snapped width.  But I'm hoping this is
just wrong.

   return gfx::Size(kWidth, GetHeightForWidth(kWidth));
 }
 
 void PermissionsBubbleDialogDelegateView::GetAccessibleNodeData(
     ui::AXNodeData* node_data) {
   views::BubbleDialogDelegateView::GetAccessibleNodeData(node_data);
   node_data->role = ui::AX_ROLE_ALERT_DIALOG;
 }
 
 int PermissionsBubbleDialogDelegateView::GetDefaultDialogButton() const {
@@ skipping 169 matching lines @@
 }
 
 void PermissionPromptImpl::Deny() {
   if (delegate_)
     delegate_->Deny();
 }
 
 Profile* PermissionPromptImpl::GetProfile() {
   return browser_->profile();
 }