Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(464)

Issue 2785683002: Add workaround for type change in webrtc api. (Closed)

Created:
3 years, 8 months ago by sprang_chromium
Modified:
3 years, 8 months ago
Reviewers:
perkj_chrome
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, chfremer+watch_chromium.org, jam, feature-media-reviews_chromium.org, darin-cc_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add workaround for type change in webrtc api. As of cl https://codereview.webrtc.org/2781433002/ the max_pixel_count type of rtc::VideoWinkWants will change from an Optional<int> to a plain int. Until that CL has landed and been imported into Chrome, use a type alias that will work with either. BUG=webrtc:4172 Review-Url: https://codereview.chromium.org/2785683002 Cr-Commit-Position: refs/heads/master@{#460356} Committed: https://chromium.googlesource.com/chromium/src/+/18899fc19e8597057da7394d470cd955487ec733

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M content/renderer/media/webrtc/webrtc_video_capturer_adapter_unittest.cc View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 11 (7 generated)
sprang_chromium
3 years, 8 months ago (2017-03-29 11:03:36 UTC) #2
perkj_chrome
lgtm
3 years, 8 months ago (2017-03-29 11:24:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2785683002/1
3 years, 8 months ago (2017-03-29 11:25:49 UTC) #8
commit-bot: I haz the power
3 years, 8 months ago (2017-03-29 11:53:30 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/18899fc19e8597057da7394d470c...

Powered by Google App Engine
This is Rietveld 408576698