Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Unified Diff: tests/language/vm/no_such_args_error_message_vm_test.dart

Issue 2785623004: Fix #14144 confusing error message misusing a callable object (Closed)
Patch Set: Realized that doing .runtimeType == _Closure is unnecessary, doing 'is' now. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tests/language/vm/no_such_args_error_message_vm_test.dart
diff --git a/tests/language/vm/no_such_args_error_message_vm_test.dart b/tests/language/vm/no_such_args_error_message_vm_test.dart
new file mode 100644
index 0000000000000000000000000000000000000000..3402472fae41422853ec2719ee24eae4e637196e
--- /dev/null
+++ b/tests/language/vm/no_such_args_error_message_vm_test.dart
@@ -0,0 +1,35 @@
+// Copyright (c) 2017, the Dart project authors. Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+// VMOptions=--optimization-counter-threshold=10 --no-use-osr --no-background-compilation
+
+import "package:expect/expect.dart";
+
+// Test error message with misusing Functions and Closures: wrong args
+// should result in a message that reports the missing method.
+
+call_with_bar(x) => x("bar");
+
+testClosureMessage() {
+ try {
+ call_with_bar(() {});
+ } catch (e) {
+ Expect.isTrue(e.toString().contains(
+ "Tried calling: testClosureMessage.<anonymous closure>(\"bar\")"));
+ }
+}
+
+noargs() {}
+
+testFunctionMessage() {
+ try {
+ call_with_bar(noargs);
+ } catch (e) {
+ Expect.isTrue(e.toString().contains("Tried calling: noargs(\"bar\")"));
+ }
+}
+
+main() {
+ for (var i = 0; i < 20; i++) testClosureMessage();
+ for (var i = 0; i < 20; i++) testFunctionMessage();
+}
« no previous file with comments | « runtime/vm/flow_graph_inliner.cc ('k') | tests/language/vm/no_such_method_error_message_callable_vm_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698