Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 2785603002: Add LayoutObject::RarePaintData for rare paint data (Closed)

Created:
3 years, 8 months ago by pdr.
Modified:
3 years, 8 months ago
Reviewers:
chrishtr, Xianzhu
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add LayoutObject::RarePaintData for rare paint data This patch adds a rare data struct to LayoutObject for paint-related data. In this patch we just use it for ObjectPaintProperties, but this sets the groundwork for splitting LocalBorderBoxProperties out of ObjectPaintProperties so it can be managed independently. Data in crbug.com/700452 [1] shows that LayoutBorderBoxProperties is needed much more than ObjectPaintProperties so this will save memory. In addition, a future patch will use store PaintLayer in this rare data, reducing one pointer from LayoutBoxModelObject. [1] https://docs.google.com/spreadsheets/d/1IC1JI0sX7QsR9FmA4G1-F9E_c3xRKDNoV3SkDKQ822U BUG=700452 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2785603002 Cr-Commit-Position: refs/heads/master@{#460885} Committed: https://chromium.googlesource.com/chromium/src/+/7f0d97dcab059b98a6825ee172c7140ff938f667

Patch Set 1 #

Patch Set 2 : PaintRareData->RarePaintData, plus cleanup #

Patch Set 3 : Rebase #

Patch Set 4 : CORE_EXPORT private struct because compilers #

Patch Set 5 : Compilers, how do they work? #

Patch Set 6 : Add back missing CORE_EXPORT #

Patch Set 7 : Use default unique_ptr ctor #

Total comments: 4

Patch Set 8 : struct->class #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -19 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutObject.h View 1 2 3 4 5 6 7 3 chunks +34 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutObject.cpp View 1 2 3 4 5 6 2 chunks +12 lines, -8 lines 0 comments Download

Messages

Total messages: 32 (24 generated)
pdr.
3 years, 8 months ago (2017-03-29 23:29:58 UTC) #11
pdr.
3 years, 8 months ago (2017-03-29 23:32:07 UTC) #12
Xianzhu
lgtm https://codereview.chromium.org/2785603002/diff/120001/third_party/WebKit/Source/core/layout/LayoutObject.cpp File third_party/WebKit/Source/core/layout/LayoutObject.cpp (right): https://codereview.chromium.org/2785603002/diff/120001/third_party/WebKit/Source/core/layout/LayoutObject.cpp#newcode3555 third_party/WebKit/Source/core/layout/LayoutObject.cpp:3555: LayoutObject::RarePaintData::RarePaintData() {} Nit: I think we can just ...
3 years, 8 months ago (2017-03-30 03:11:18 UTC) #22
pdr.
https://codereview.chromium.org/2785603002/diff/120001/third_party/WebKit/Source/core/layout/LayoutObject.cpp File third_party/WebKit/Source/core/layout/LayoutObject.cpp (right): https://codereview.chromium.org/2785603002/diff/120001/third_party/WebKit/Source/core/layout/LayoutObject.cpp#newcode3555 third_party/WebKit/Source/core/layout/LayoutObject.cpp:3555: LayoutObject::RarePaintData::RarePaintData() {} On 2017/03/30 at 03:11:18, Xianzhu wrote: > ...
3 years, 8 months ago (2017-03-30 18:57:33 UTC) #25
pdr.
PTAL, if you like this please send to the CQ
3 years, 8 months ago (2017-03-30 18:58:02 UTC) #26
Xianzhu
lgtm
3 years, 8 months ago (2017-03-30 19:00:19 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2785603002/140001
3 years, 8 months ago (2017-03-30 19:01:11 UTC) #29
commit-bot: I haz the power
3 years, 8 months ago (2017-03-30 21:30:32 UTC) #32
Message was sent while issue was closed.
Committed patchset #8 (id:140001) as
https://chromium.googlesource.com/chromium/src/+/7f0d97dcab059b98a6825ee172c7...

Powered by Google App Engine
This is Rietveld 408576698