Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 2785583002: [SPInvalidation] Always inline the internal methods of PaintLayerClipper (Closed)

Created:
3 years, 8 months ago by chrishtr
Modified:
3 years, 8 months ago
Reviewers:
pdr.
CC:
blink-reviews, blink-reviews-paint_chromium.org, chromium-reviews, dshwang
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[SPInvalidation] Always inline the internal methods of PaintLayerClipper. In local runs with SlimmingPaintInvalidation turned on, this improves rasterize_and_record_micro.partial_invalidation/subsequence_caching_disabled from about 0.82ms to 0.62ms, a 25% improvement. BUG=699198 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2785583002 Cr-Commit-Position: refs/heads/master@{#460278} Committed: https://chromium.googlesource.com/chromium/src/+/9c0482de8c913c46a62bb22b2f22a217e52dbf05

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -11 lines) Patch
M third_party/WebKit/Source/core/paint/PaintLayerClipper.h View 2 chunks +12 lines, -11 lines 0 comments Download

Messages

Total messages: 20 (14 generated)
chrishtr
3 years, 8 months ago (2017-03-29 00:48:11 UTC) #4
pdr.
LGTM
3 years, 8 months ago (2017-03-29 00:57:43 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2785583002/1
3 years, 8 months ago (2017-03-29 01:03:19 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_TIMED_OUT, build hasn't started yet, builder ...
3 years, 8 months ago (2017-03-29 02:51:24 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2785583002/1
3 years, 8 months ago (2017-03-29 03:20:10 UTC) #17
commit-bot: I haz the power
3 years, 8 months ago (2017-03-29 04:30:19 UTC) #20
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9c0482de8c913c46a62bb22b2f22...

Powered by Google App Engine
This is Rietveld 408576698