Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(418)

Issue 2785563002: Expire but don't clear HostCache on DNS config change (Closed)

Created:
3 years, 8 months ago by mgersh
Modified:
3 years, 8 months ago
Reviewers:
Julia Tuttle
CC:
chromium-reviews, cbentzel+watch_chromium.org, bnc+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Expire but don't clear HostCache on DNS config change Before this change, HostCache entries are expired (not cleared) on IP address changes, but the entire cache is cleared on DNS config changes. This isn't useful because the distinction is currently only used in an Android-specific experiment, and all network changes on Android involve a DNS config change. Cronet with the stale DNS experiment enabled will now use HostCache entries from other networks if the allow_other_network option is turned on. Chrome itself should not have any changes other than keeping more results in cache that won't be used. BUG=691078 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester Review-Url: https://codereview.chromium.org/2785563002 Cr-Commit-Position: refs/heads/master@{#460401} Committed: https://chromium.googlesource.com/chromium/src/+/92b1af1d8a6162a1a9638d02c3485363ffb60abd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -2 lines) Patch
M components/cronet/stale_host_resolver_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M net/base/network_change_notifier.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/base/network_change_notifier.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M net/dns/host_resolver_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
mgersh
Oops. I didn't understand enough of how network changes work when I did https://codereview.chromium.org/2692043002/ so ...
3 years, 8 months ago (2017-03-28 21:58:57 UTC) #3
Julia Tuttle
lgtm! Hope it works this time.
3 years, 8 months ago (2017-03-28 22:07:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2785563002/1
3 years, 8 months ago (2017-03-29 14:43:40 UTC) #6
commit-bot: I haz the power
3 years, 8 months ago (2017-03-29 15:50:20 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/92b1af1d8a6162a1a9638d02c348...

Powered by Google App Engine
This is Rietveld 408576698