Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(472)

Issue 2785553002: Reland of Disable failing blink_style.key_mobile_sites (Closed)

Created:
3 years, 8 months ago by rnephew (Reviews Here)
Modified:
3 years, 8 months ago
Reviewers:
sullivan, nednguyen
CC:
chromium-reviews, telemetry-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Disable failing blink_style.key_mobile_sites (patchset #1 id:1 of https://codereview.chromium.org/2768683005/ ) Reason for revert: The tests are still failing in the same way. Original issue's description: > Revert of Disable failing blink_style.key_mobile_sites (patchset #1 id:1 of https://codereview.chromium.org/2758533003/ ) > > Reason for revert: > Root cause should be fixed. > > Original issue's description: > > Disable failing blink_style.key_mobile_sites > > > > BUG=702194 > > > > Review-Url: https://codereview.chromium.org/2758533003 > > Cr-Commit-Position: refs/heads/master@{#457432} > > Committed: https://chromium.googlesource.com/chromium/src/+/4d954851ba9c129b4529302f77862f6b812165d8 > > TBR=sullivan@chromium.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=702194 > > Review-Url: https://codereview.chromium.org/2768683005 > Cr-Commit-Position: refs/heads/master@{#458730} > Committed: https://chromium.googlesource.com/chromium/src/+/c4928c8fba4766c4fb25cbb0ecce574101b29aca TBR=sullivan@chromium.org,nednguyen@google.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=702194

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M tools/perf/benchmarks/blink_style.py View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
rnephew (Reviews Here)
Created Reland of Disable failing blink_style.key_mobile_sites
3 years, 8 months ago (2017-03-28 21:33:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2785553002/1
3 years, 8 months ago (2017-03-28 21:34:24 UTC) #3
rnephew (Reviews Here)
On 2017/03/28 21:34:24, commit-bot: I haz the power wrote: > CQ is trying da patch. ...
3 years, 8 months ago (2017-03-28 22:01:10 UTC) #5
rnephew (Reviews Here)
3 years, 8 months ago (2017-03-28 22:02:25 UTC) #6
On 2017/03/28 22:01:10, rnephew (Reviews Here) wrote:
> On 2017/03/28 21:34:24, commit-bot: I haz the power wrote:
> > CQ is trying da patch. Follow status at
> >  
> >
>
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
> 
> Reverted wrong cl, this one only does blink_style, I need the one that
disables
> the other benchmarks as well.

Actually, there are 2 different CLs that need to be reverted. I'm going to just
make a new one that merges those two so we only have to deal with one CL when
this is fixed.

Powered by Google App Engine
This is Rietveld 408576698