Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 2768683005: Revert of Disable failing blink_style.key_mobile_sites (Closed)

Created:
3 years, 9 months ago by nednguyen
Modified:
3 years, 9 months ago
Reviewers:
sullivan
CC:
chromium-reviews, telemetry-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Disable failing blink_style.key_mobile_sites (patchset #1 id:1 of https://codereview.chromium.org/2758533003/ ) Reason for revert: Root cause should be fixed. Original issue's description: > Disable failing blink_style.key_mobile_sites > > BUG=702194 > > Review-Url: https://codereview.chromium.org/2758533003 > Cr-Commit-Position: refs/heads/master@{#457432} > Committed: https://chromium.googlesource.com/chromium/src/+/4d954851ba9c129b4529302f77862f6b812165d8 TBR=sullivan@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=702194 Review-Url: https://codereview.chromium.org/2768683005 Cr-Commit-Position: refs/heads/master@{#458730} Committed: https://chromium.googlesource.com/chromium/src/+/c4928c8fba4766c4fb25cbb0ecce574101b29aca

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M tools/perf/benchmarks/blink_style.py View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
nednguyen
Created Revert of Disable failing blink_style.key_mobile_sites
3 years, 9 months ago (2017-03-22 12:20:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2768683005/1
3 years, 9 months ago (2017-03-22 12:20:21 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/c4928c8fba4766c4fb25cbb0ecce574101b29aca
3 years, 9 months ago (2017-03-22 13:25:18 UTC) #6
rnephew (Reviews Here)
3 years, 8 months ago (2017-03-28 21:33:36 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2785553002/ by rnephew@chromium.org.

The reason for reverting is: The tests are still failing in the same way..

Powered by Google App Engine
This is Rietveld 408576698