Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2785543002:
Default to range to "limited" when getting color space from container. (Closed)
|
Created:
3 years, 8 months ago by hubbe Modified:
3 years, 8 months ago Reviewers:
DaleCurtis CC:
chromium-reviews, feature-media-reviews_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionDefault to range to "limited" when getting color space from container.
The range is often not known, and right now the code defaults to full range in that case which is almost always wrong.
Review-Url: https://codereview.chromium.org/2785543002
Cr-Commit-Position: refs/heads/master@{#460416}
Committed: https://chromium.googlesource.com/chromium/src/+/cfbe57b14b14dcda36b60f67eeab46ccdd40c65e
Patch Set 1 #
Messages
Total messages: 20 (10 generated)
The CQ bit was checked by hubbe@chromium.org to run a CQ dry run
hubbe@chromium.org changed reviewers: + dalecurtis@chromium.org
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: CQ has no permission to schedule in bucket master.tryserver.chromium.linux
How confident are you in always? I.e. what does a sampling of YouTube, Vimeo, Facebook return?
On 2017/03/28 21:32:11, DaleCurtis wrote: > How confident are you in always? I.e. what does a sampling of YouTube, Vimeo, > Facebook return? I'm 100% sure that --enable-features=video-color-space changes what chrome does with untagged videos in a very bad way without this change. I'm not sure what percentage of videos are full range, but those videos need to be tagged correctly, as has always been the case.
Are untagged videos common on the sites I mentioned?
lgtm in any case, just curious about the impact here.
The CQ bit was checked by hubbe@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On 2017/03/29 00:21:36, DaleCurtis wrote: > Are untagged videos common on the sites I mentioned? Probably, the majority of videos seems to be untagged, so unless those sites add tags, the videos would still be untagged. However, this code only affects the ffmpeg demuxer, not MSE, which I think all of those sites use.
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_TIMED_OUT, build hasn't started yet, builder probably lacks capacity)
The CQ bit was checked by hubbe@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1490804350028750, "parent_rev":
"9327ce925b77f722c31116f5e08cff23df70908d", "commit_rev":
"cfbe57b14b14dcda36b60f67eeab46ccdd40c65e"}
Message was sent while issue was closed.
Description was changed from ========== Default to range to "limited" when getting color space from container. The range is often not known, and right now the code defaults to full range in that case which is almost always wrong. ========== to ========== Default to range to "limited" when getting color space from container. The range is often not known, and right now the code defaults to full range in that case which is almost always wrong. Review-Url: https://codereview.chromium.org/2785543002 Cr-Commit-Position: refs/heads/master@{#460416} Committed: https://chromium.googlesource.com/chromium/src/+/cfbe57b14b14dcda36b60f67eeab... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/cfbe57b14b14dcda36b60f67eeab... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
