Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 2785533002: DevTools: Show event initiator on Flame Chart for selected entries (Closed)

Created:
3 years, 8 months ago by alph
Modified:
3 years, 8 months ago
Reviewers:
caseq, pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Show event initiator on Flame Chart for selected entries BUG=646928 Review-Url: https://codereview.chromium.org/2785533002 Cr-Commit-Position: refs/heads/master@{#460497} Committed: https://chromium.googlesource.com/chromium/src/+/5135ba101f2a688c8b90f9df43df5abca4279a54

Patch Set 1 #

Patch Set 2 : v2 #

Patch Set 3 : hide behind an experiments #

Patch Set 4 : sort experiments #

Messages

Total messages: 18 (8 generated)
alph
3 years, 8 months ago (2017-03-28 21:04:55 UTC) #2
caseq
lgtm
3 years, 8 months ago (2017-03-28 23:02:27 UTC) #3
pfeldman
not lgtm - this feature is not ready.
3 years, 8 months ago (2017-03-28 23:45:08 UTC) #4
pfeldman
(as discussed offline, we can launch this behind experiment and iterate on it, but it ...
3 years, 8 months ago (2017-03-28 23:48:41 UTC) #5
alph
ptal
3 years, 8 months ago (2017-03-29 00:05:09 UTC) #6
pfeldman
lgtm, but please sort the experiments
3 years, 8 months ago (2017-03-29 04:15:11 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2785533002/60001
3 years, 8 months ago (2017-03-29 15:53:25 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/419143)
3 years, 8 months ago (2017-03-29 17:21:35 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2785533002/60001
3 years, 8 months ago (2017-03-29 18:16:09 UTC) #15
commit-bot: I haz the power
3 years, 8 months ago (2017-03-29 19:44:23 UTC) #18
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/5135ba101f2a688c8b90f9df43df...

Powered by Google App Engine
This is Rietveld 408576698