Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 2785503003: Image Capture: update PhotoCapabilities.idl to latest Spec changes (Closed)

Created:
3 years, 8 months ago by mcasas
Modified:
3 years, 8 months ago
CC:
chromium-reviews, blink-reviews, haraken, mcasas+imagecapture_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Image Capture: update PhotoCapabilities.idl to latest Spec changes This CL updates PhotoCapabilities.idl and associated logic to the extent possible before touching the mojo interface, which essentially means: - |redEyeReduction| changes to be an enum of supported modes - |fillLightMode| changes to be an array of supported modes Referring to the following Spec PRs : https://github.com/w3c/mediacapture-image/pull/164 (which addressed https://github.com/w3c/mediacapture-image/issues/163) and https://github.com/w3c/mediacapture-image/pull/165 (which addressed https://github.com/w3c/mediacapture-image/issues/156) BUG=706171 Review-Url: https://codereview.chromium.org/2785503003 Cr-Commit-Position: refs/heads/master@{#460480} Committed: https://chromium.googlesource.com/chromium/src/+/38d77c83ff942c116f8653dba2c643f63e16ae7f

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -40 lines) Patch
M third_party/WebKit/LayoutTests/imagecapture/getphotocapabilities.html View 2 chunks +6 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/imagecapture/ImageCapture.cpp View 3 chunks +17 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/modules/imagecapture/PhotoCapabilities.h View 3 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/modules/imagecapture/PhotoCapabilities.cpp View 1 chunk +21 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/modules/imagecapture/PhotoCapabilities.idl View 1 chunk +10 lines, -6 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
mcasas
reillyg@ PTAL (spec catch-up)
3 years, 8 months ago (2017-03-29 17:36:19 UTC) #4
Reilly Grant (use Gerrit)
lgtm
3 years, 8 months ago (2017-03-29 18:11:21 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2785503003/20001
3 years, 8 months ago (2017-03-29 18:17:57 UTC) #7
commit-bot: I haz the power
3 years, 8 months ago (2017-03-29 19:10:51 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/38d77c83ff942c116f8653dba2c6...

Powered by Google App Engine
This is Rietveld 408576698