Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issue 2785503002: Revert of [package.proto] convert deps from list to map. (Closed)

Created:
3 years, 8 months ago by iannucci
Modified:
3 years, 8 months ago
CC:
chromium-reviews, infra-reviews+recipes-py_chromium.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert of [package.proto] convert deps from list to map. (patchset #3 id:40001 of https://codereview.chromium.org/2779683005/ ) Reason for revert: Prepping revert <just in case> Original issue's description: > [package.proto] convert deps from list to map. > > This is a backwards-incompatible proto change, but this CL makes the engine > compatible with BOTH versions (simultaneously :)). > > Files handled by e.g. the autoroller code are 'sticky'. If they were > version 1, they'll be written as version 1. If they were version 2, they'll > be written as version 2. > > Once version 2 is in use everywhere, I will remove support for version 1. > > R=dnj@chromium.org, nodir@chromium.rog, phajdan.jr@chromium.org > BUG= > > Review-Url: https://codereview.chromium.org/2779683005 > Committed: https://github.com/luci/recipes-py/commit/4fcdb75517198a9ca32c7c4aecbe2e6f54b8b6c2 TBR=dnj@chromium.org,nodir@chromium.org,phajdan.jr@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+114 lines, -206 lines) Patch
M recipe_engine/package.proto View 3 chunks +12 lines, -7 lines 0 comments Download
M recipe_engine/package.py View 8 chunks +18 lines, -43 lines 0 comments Download
M recipe_engine/package_pb2.py View 10 chunks +39 lines, -81 lines 0 comments Download
M unittests/package_test.py View 3 chunks +32 lines, -67 lines 0 comments Download
M unittests/repo_test_util.py View 1 chunk +8 lines, -5 lines 0 comments Download
M unittests/test_test.py View 1 chunk +5 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
iannucci
Created Revert of [package.proto] convert deps from list to map.
3 years, 8 months ago (2017-03-28 16:16:42 UTC) #1
iannucci
This is just in case it looks like it goes sideways.
3 years, 8 months ago (2017-03-28 16:17:15 UTC) #2
iannucci
3 years, 8 months ago (2017-03-28 16:42:21 UTC) #3
woohoo! not needed

Powered by Google App Engine
This is Rietveld 408576698