Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(748)

Unified Diff: ios/web_view/internal/translate/web_view_translate_ranker_factory.cc

Issue 2785493004: Integrate RankerModelLoader with TranslateRanker. (Closed)
Patch Set: fix bogus compile error Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/web_view/internal/translate/web_view_translate_ranker_factory.cc
diff --git a/ios/web_view/internal/translate/web_view_translate_ranker_factory.cc b/ios/web_view/internal/translate/web_view_translate_ranker_factory.cc
new file mode 100644
index 0000000000000000000000000000000000000000..f863bdf5ac01a8c01db41d72e9c952f50abfc4d9
--- /dev/null
+++ b/ios/web_view/internal/translate/web_view_translate_ranker_factory.cc
@@ -0,0 +1,53 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "ios/web_view/internal/translate/web_view_translate_ranker_factory.h"
+
+#include <utility>
+
+#include "base/memory/ptr_util.h"
+#include "base/memory/singleton.h"
+#include "components/keyed_service/core/keyed_service.h"
+#include "components/keyed_service/ios/browser_state_dependency_manager.h"
+#include "components/translate/core/browser/translate_ranker_impl.h"
+#include "ios/web_view/internal/pref_names.h"
+#include "ios/web_view/internal/web_view_browser_state.h"
+
+namespace ios_web_view {
+
+// static
+WebViewTranslateRankerFactory* WebViewTranslateRankerFactory::GetInstance() {
+ return base::Singleton<WebViewTranslateRankerFactory>::get();
+}
+
+// static
+translate::TranslateRanker* WebViewTranslateRankerFactory::GetForBrowserState(
+ WebViewBrowserState* state) {
+ return static_cast<translate::TranslateRanker*>(
+ GetInstance()->GetServiceForBrowserState(state, true));
+}
+
+WebViewTranslateRankerFactory::WebViewTranslateRankerFactory()
+ : BrowserStateKeyedServiceFactory(
+ "TranslateRankerService",
+ BrowserStateDependencyManager::GetInstance()) {}
+
+WebViewTranslateRankerFactory::~WebViewTranslateRankerFactory() {}
+
+std::unique_ptr<KeyedService>
+WebViewTranslateRankerFactory::BuildServiceInstanceFor(
+ web::BrowserState* context) const {
+ WebViewBrowserState* web_view_browser_state =
+ WebViewBrowserState::FromBrowserState(context);
+ std::unique_ptr<translate::TranslateRankerImpl> ranker =
+ base::MakeUnique<translate::TranslateRankerImpl>(
+ translate::TranslateRankerImpl::GetModelPath(
+ web_view_browser_state->GetStatePath()),
+ translate::TranslateRankerImpl::GetModelURL());
+ // WebView has no consumer of translate ranker events, so don't generate them.
+ ranker->EnableLogging(false);
+ return std::move(ranker); // Fails xcode-clang compile without the move.
sdefresne 2017/04/05 09:33:43 Please change to the following so we can clean thi
Roger McFarlane (Chromium) 2017/04/07 02:35:07 Oops! Missed this. Created and landed https://cod
+}
+
+} // namespace ios_web_view
« no previous file with comments | « ios/web_view/internal/translate/web_view_translate_ranker_factory.h ('k') | testing/variations/fieldtrial_testing_config.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698