Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Side by Side Diff: ios/web_view/internal/translate/web_view_translate_ranker_factory.cc

Issue 2785493004: Integrate RankerModelLoader with TranslateRanker. (Closed)
Patch Set: fix bogus compile error Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "ios/web_view/internal/translate/web_view_translate_ranker_factory.h"
6
7 #include <utility>
8
9 #include "base/memory/ptr_util.h"
10 #include "base/memory/singleton.h"
11 #include "components/keyed_service/core/keyed_service.h"
12 #include "components/keyed_service/ios/browser_state_dependency_manager.h"
13 #include "components/translate/core/browser/translate_ranker_impl.h"
14 #include "ios/web_view/internal/pref_names.h"
15 #include "ios/web_view/internal/web_view_browser_state.h"
16
17 namespace ios_web_view {
18
19 // static
20 WebViewTranslateRankerFactory* WebViewTranslateRankerFactory::GetInstance() {
21 return base::Singleton<WebViewTranslateRankerFactory>::get();
22 }
23
24 // static
25 translate::TranslateRanker* WebViewTranslateRankerFactory::GetForBrowserState(
26 WebViewBrowserState* state) {
27 return static_cast<translate::TranslateRanker*>(
28 GetInstance()->GetServiceForBrowserState(state, true));
29 }
30
31 WebViewTranslateRankerFactory::WebViewTranslateRankerFactory()
32 : BrowserStateKeyedServiceFactory(
33 "TranslateRankerService",
34 BrowserStateDependencyManager::GetInstance()) {}
35
36 WebViewTranslateRankerFactory::~WebViewTranslateRankerFactory() {}
37
38 std::unique_ptr<KeyedService>
39 WebViewTranslateRankerFactory::BuildServiceInstanceFor(
40 web::BrowserState* context) const {
41 WebViewBrowserState* web_view_browser_state =
42 WebViewBrowserState::FromBrowserState(context);
43 std::unique_ptr<translate::TranslateRankerImpl> ranker =
44 base::MakeUnique<translate::TranslateRankerImpl>(
45 translate::TranslateRankerImpl::GetModelPath(
46 web_view_browser_state->GetStatePath()),
47 translate::TranslateRankerImpl::GetModelURL());
48 // WebView has no consumer of translate ranker events, so don't generate them.
49 ranker->EnableLogging(false);
50 return std::move(ranker); // Fails xcode-clang compile without the move.
sdefresne 2017/04/05 09:33:43 Please change to the following so we can clean thi
Roger McFarlane (Chromium) 2017/04/07 02:35:07 Oops! Missed this. Created and landed https://cod
51 }
52
53 } // namespace ios_web_view
OLDNEW
« no previous file with comments | « ios/web_view/internal/translate/web_view_translate_ranker_factory.h ('k') | testing/variations/fieldtrial_testing_config.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698