ios/web_view/internal/translate/web_view_translate_client.mm - Issue 2785493004: Integrate RankerModelLoader with TranslateRanker.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/web_view/internal/translate/web_view_translate_client.mm

Issue 2785493004: Integrate RankerModelLoader with TranslateRanker. (Closed)

Patch Set: fix bogus compile error Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ios/web_view/internal/translate/web_view_translate_client.mm

diff --git a/ios/web_view/internal/translate/web_view_translate_client.mm b/ios/web_view/internal/translate/web_view_translate_client.mm

index d0f717101e66fa42089be8b1c488392cc072b03f..6b8ee429b9f5a4d9318d59ca9c9976062c7e9da7 100644

--- a/ios/web_view/internal/translate/web_view_translate_client.mm

+++ b/ios/web_view/internal/translate/web_view_translate_client.mm

@@ -22,6 +22,7 @@

#include "ios/web_view/internal/pref_names.h"

#import "ios/web_view/internal/translate/cwv_translate_manager_impl.h"

#include "ios/web_view/internal/translate/web_view_translate_accept_languages_factory.h"

+#include "ios/web_view/internal/translate/web_view_translate_ranker_factory.h"

#include "ios/web_view/internal/web_view_browser_state.h"

#import "ios/web_view/public/cwv_translate_delegate.h"

#include "url/gurl.h"

@@ -38,6 +39,9 @@ WebViewTranslateClient::WebViewTranslateClient(web::WebState* web_state)

: web::WebStateObserver(web_state),

translate_manager_(base::MakeUnique<translate::TranslateManager>(

this,

+ WebViewTranslateRankerFactory::GetForBrowserState(

+ WebViewBrowserState::FromBrowserState(

+ web_state->GetBrowserState())),

prefs::kAcceptLanguages)),

translate_driver_(web_state,

web_state->GetNavigationManager(),