Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3685)

Unified Diff: third_party/WebKit/Source/modules/sensor/OrientationSensor.h

Issue 2785493002: [Sensors] OrientationSensor.populateMatrix() works also with Float64Array and DOMMatrix types (Closed)
Patch Set: Comments from Reilly Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/sensor/OrientationSensor.h
diff --git a/third_party/WebKit/Source/modules/sensor/OrientationSensor.h b/third_party/WebKit/Source/modules/sensor/OrientationSensor.h
index 52c20a7e17606563699328040486325820c4e7a1..19e219f50c564be79304a43a5122c00422c7aa5a 100644
--- a/third_party/WebKit/Source/modules/sensor/OrientationSensor.h
+++ b/third_party/WebKit/Source/modules/sensor/OrientationSensor.h
@@ -5,6 +5,7 @@
#ifndef OrientationSensor_h
#define OrientationSensor_h
+#include "bindings/modules/v8/Float32ArrayOrFloat64ArrayOrDOMMatrix.h"
#include "core/dom/DOMTypedArray.h"
#include "modules/sensor/Sensor.h"
@@ -15,7 +16,7 @@ class OrientationSensor : public Sensor {
public:
Vector<double> quaternion(bool& isNull);
- void populateMatrix(DOMFloat32Array*, ExceptionState&);
+ void populateMatrix(Float32ArrayOrFloat64ArrayOrDOMMatrix&, ExceptionState&);
bool isReadingDirty() const;
@@ -30,6 +31,8 @@ class OrientationSensor : public Sensor {
private:
// SensorProxy override.
void onSensorReadingChanged() override;
+ template <typename Matrix>
+ void populateMatrixInternal(Matrix*, ExceptionState&);
bool m_readingDirty;
};

Powered by Google App Engine
This is Rietveld 408576698