Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(868)

Side by Side Diff: third_party/WebKit/Source/modules/sensor/OrientationSensor.h

Issue 2785493002: [Sensors] OrientationSensor.populateMatrix() works also with Float64Array and DOMMatrix types (Closed)
Patch Set: Comments from Reilly Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2017 The Chromium Authors. All rights reserved. 1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef OrientationSensor_h 5 #ifndef OrientationSensor_h
6 #define OrientationSensor_h 6 #define OrientationSensor_h
7 7
8 #include "bindings/modules/v8/Float32ArrayOrFloat64ArrayOrDOMMatrix.h"
8 #include "core/dom/DOMTypedArray.h" 9 #include "core/dom/DOMTypedArray.h"
9 #include "modules/sensor/Sensor.h" 10 #include "modules/sensor/Sensor.h"
10 11
11 namespace blink { 12 namespace blink {
12 13
13 class OrientationSensor : public Sensor { 14 class OrientationSensor : public Sensor {
14 DEFINE_WRAPPERTYPEINFO(); 15 DEFINE_WRAPPERTYPEINFO();
15 16
16 public: 17 public:
17 Vector<double> quaternion(bool& isNull); 18 Vector<double> quaternion(bool& isNull);
18 void populateMatrix(DOMFloat32Array*, ExceptionState&); 19 void populateMatrix(Float32ArrayOrFloat64ArrayOrDOMMatrix&, ExceptionState&);
19 20
20 bool isReadingDirty() const; 21 bool isReadingDirty() const;
21 22
22 DECLARE_VIRTUAL_TRACE(); 23 DECLARE_VIRTUAL_TRACE();
23 24
24 protected: 25 protected:
25 OrientationSensor(ExecutionContext*, 26 OrientationSensor(ExecutionContext*,
26 const SensorOptions&, 27 const SensorOptions&,
27 ExceptionState&, 28 ExceptionState&,
28 device::mojom::blink::SensorType); 29 device::mojom::blink::SensorType);
29 30
30 private: 31 private:
31 // SensorProxy override. 32 // SensorProxy override.
32 void onSensorReadingChanged() override; 33 void onSensorReadingChanged() override;
34 template <typename Matrix>
35 void populateMatrixInternal(Matrix*, ExceptionState&);
33 36
34 bool m_readingDirty; 37 bool m_readingDirty;
35 }; 38 };
36 39
37 } // namespace blink 40 } // namespace blink
38 41
39 #endif // OrientationSensor_h 42 #endif // OrientationSensor_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698