Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2785463003:
Remove IPC Message start entry ExtensionUtilityMsgStart (Closed)
|
Created:
3 years, 8 months ago by Noel Gordon Modified:
3 years, 8 months ago Reviewers:
Tom Sepez CC:
chromium-reviews, jam, darin-cc_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionRemove IPC Message start entry ExtensionUtilityMsgStart
The extensions/common/extension_utility_messages.h message
file was deleted in http://crrev.com/460280
Its corresponding IPC START entry ExtensionUtilityMsgStart
is not needed either, so we can remove it.
BUG=691410
Review-Url: https://codereview.chromium.org/2785463003
Cr-Commit-Position: refs/heads/master@{#460564}
Committed: https://chromium.googlesource.com/chromium/src/+/0a5a46198c69904bc7d92d27a2b1ab654a52ef1b
Patch Set 1 #
Messages
Total messages: 16 (12 generated)
noel@chromium.org changed reviewers: + tsepez@chromium.org
PTAL.
The CQ bit was checked by noel@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Remove IPC Message start entry ExtensionUtilityMsgStart http://crrev.com/460280 deleted extensions/common/extension_utility_messages.h and the corresponding IPC START entry, ExtensionUtilityMsgStart, is not needed so we can remove it. BUG=691410 ========== to ========== Remove IPC Message start entry ExtensionUtilityMsgStart http://crrev.com/460280 deleted message file extensions/common/extension_utility_messages.h The corresponding IPC START entry, ExtensionUtilityMsgStart, is not needed so we can remove it. BUG=691410 ==========
Description was changed from ========== Remove IPC Message start entry ExtensionUtilityMsgStart http://crrev.com/460280 deleted message file extensions/common/extension_utility_messages.h The corresponding IPC START entry, ExtensionUtilityMsgStart, is not needed so we can remove it. BUG=691410 ========== to ========== Remove IPC Message start entry ExtensionUtilityMsgStart http://crrev.com/460280 deleted message file extensions/common/extension_utility_messages.h The corresponding IPC START entry, ExtensionUtilityMsgStart, is not needed so we can remove it. BUG=691410 ==========
Description was changed from ========== Remove IPC Message start entry ExtensionUtilityMsgStart http://crrev.com/460280 deleted message file extensions/common/extension_utility_messages.h The corresponding IPC START entry, ExtensionUtilityMsgStart, is not needed so we can remove it. BUG=691410 ========== to ========== Remove IPC Message start entry ExtensionUtilityMsgStart http://crrev.com/460280 deleted message file: extensions/common/extension_utility_messages.h The corresponding IPC START entry, ExtensionUtilityMsgStart, is not needed so we can remove it. BUG=691410 ==========
Description was changed from ========== Remove IPC Message start entry ExtensionUtilityMsgStart http://crrev.com/460280 deleted message file: extensions/common/extension_utility_messages.h The corresponding IPC START entry, ExtensionUtilityMsgStart, is not needed so we can remove it. BUG=691410 ========== to ========== Remove IPC Message start entry ExtensionUtilityMsgStart The extensions/common/extension_utility_messages.h message file was deleted in http://crrev.com/460280 Its corresponding IPC START entry ExtensionUtilityMsgStart is not needed either, so we can remove it. BUG=691410 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm yay. Thanks.
The CQ bit was checked by noel@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1490827960607240, "parent_rev":
"2f5bb6155b40ff1533e4310f18e294ab34b55f14", "commit_rev":
"0a5a46198c69904bc7d92d27a2b1ab654a52ef1b"}
Message was sent while issue was closed.
Description was changed from ========== Remove IPC Message start entry ExtensionUtilityMsgStart The extensions/common/extension_utility_messages.h message file was deleted in http://crrev.com/460280 Its corresponding IPC START entry ExtensionUtilityMsgStart is not needed either, so we can remove it. BUG=691410 ========== to ========== Remove IPC Message start entry ExtensionUtilityMsgStart The extensions/common/extension_utility_messages.h message file was deleted in http://crrev.com/460280 Its corresponding IPC START entry ExtensionUtilityMsgStart is not needed either, so we can remove it. BUG=691410 Review-Url: https://codereview.chromium.org/2785463003 Cr-Commit-Position: refs/heads/master@{#460564} Committed: https://chromium.googlesource.com/chromium/src/+/0a5a46198c69904bc7d92d27a2b1... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/0a5a46198c69904bc7d92d27a2b1... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
