Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2785433003:
Add --enable-hdr to about:flags (Closed)
DescriptionAdd --enable-hdr to about:flags
EOM
BUG=682416
Review-Url: https://codereview.chromium.org/2785433003
Cr-Commit-Position: refs/heads/master@{#462249}
Committed: https://chromium.googlesource.com/chromium/src/+/e749951e2d9689e61ba9b72ada59ab04166e4927
Patch Set 1 #
Total comments: 4
Patch Set 2 : updated wording #Patch Set 3 : update histograms.xml #
Messages
Total messages: 30 (20 generated)
The CQ bit was checked by hubbe@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
hubbe@chromium.org changed reviewers: + ccameron@chromium.org
We may hold of checking this in for a few days to wait for additional testing, but I want to make sure it's reviewed and ready to go.
lgtm w/some suggestions https://codereview.chromium.org/2785433003/diff/1/chrome/browser/flag_descrip... File chrome/browser/flag_descriptions.cc (right): https://codereview.chromium.org/2785433003/diff/1/chrome/browser/flag_descrip... chrome/browser/flag_descriptions.cc:948: const char kEnableHDRName[] = "HDR Mode"; I'd prefer calling it something like "HDR support" as opposed to HDR mode". Nit for style: only first word should be capitalized. https://codereview.chromium.org/2785433003/diff/1/chrome/browser/flag_descrip... chrome/browser/flag_descriptions.cc:951: "Enables full HDR support on HDR-compatible displays."; Nit: "Enables HDR support on compatible displays."
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by hubbe@chromium.org to run a CQ dry run
https://codereview.chromium.org/2785433003/diff/1/chrome/browser/flag_descrip... File chrome/browser/flag_descriptions.cc (right): https://codereview.chromium.org/2785433003/diff/1/chrome/browser/flag_descrip... chrome/browser/flag_descriptions.cc:948: const char kEnableHDRName[] = "HDR Mode"; On 2017/03/28 19:46:35, ccameron wrote: > I'd prefer calling it something like "HDR support" as opposed to HDR mode". Nit > for style: only first word should be capitalized. I really think "mode" is the right word, since it affects how everything is rendered in chrome. "HDR support" just sounds like adding something on. https://codereview.chromium.org/2785433003/diff/1/chrome/browser/flag_descrip... chrome/browser/flag_descriptions.cc:951: "Enables full HDR support on HDR-compatible displays."; On 2017/03/28 19:46:35, ccameron wrote: > Nit: "Enables HDR support on compatible displays." Done. (I blame my PM for the wording..)
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
sgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by hubbe@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_TIMED_OUT, build hasn't started yet, builder probably lacks capacity)
hubbe@chromium.org changed reviewers: + mpearson@chromium.org
+mpearson for histograms.xml
histograms.xml lgtm
The CQ bit was checked by hubbe@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from ccameron@chromium.org Link to the patchset: https://codereview.chromium.org/2785433003/#ps40001 (title: "update histograms.xml")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
The CQ bit was checked by hubbe@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1491429458855480,
"parent_rev": "bf0af481a0f9ef2c3e0b4bdfddb90ffe12eb2f6a", "commit_rev":
"e749951e2d9689e61ba9b72ada59ab04166e4927"}
Message was sent while issue was closed.
Description was changed from ========== Add --enable-hdr to about:flags EOM BUG=682416 ========== to ========== Add --enable-hdr to about:flags EOM BUG=682416 Review-Url: https://codereview.chromium.org/2785433003 Cr-Commit-Position: refs/heads/master@{#462249} Committed: https://chromium.googlesource.com/chromium/src/+/e749951e2d9689e61ba9b72ada59... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/e749951e2d9689e61ba9b72ada59... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
