Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Issue 278543003: New tests case for verifying not sized template-areas use auto-{columns,rows}. (Closed)

Created:
6 years, 7 months ago by jfernandez
Modified:
6 years, 7 months ago
CC:
blink-reviews, svillar, jfernandez, Manuel Rego
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

New tests case for verifying not sized template-areas use auto-{columns,rows}. Any rows/columns defined by grid-template-areas but not sized by grid-template-rows/grid-template-columns take their size from the grid-auto-rows/grid-auto-columns properties. BUG=79180 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174607

Patch Set 1 #

Total comments: 2

Patch Set 2 : Applied suggested changes. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M LayoutTests/fast/css-grid-layout/grid-auto-columns-rows-resolution.html View 1 2 chunks +11 lines, -0 lines 0 comments Download
M LayoutTests/fast/css-grid-layout/grid-auto-columns-rows-resolution-expected.txt View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
jfernandez
6 years, 7 months ago (2014-05-14 14:43:01 UTC) #1
Manuel Rego
https://codereview.chromium.org/278543003/diff/1/LayoutTests/fast/css-grid-layout/grid-auto-columns-rows-resolution.html File LayoutTests/fast/css-grid-layout/grid-auto-columns-rows-resolution.html (right): https://codereview.chromium.org/278543003/diff/1/LayoutTests/fast/css-grid-layout/grid-auto-columns-rows-resolution.html#newcode17 LayoutTests/fast/css-grid-layout/grid-auto-columns-rows-resolution.html:17: grid-template-areas: "first second"; I'd define 2 rows too, in ...
6 years, 7 months ago (2014-05-14 15:11:33 UTC) #2
jfernandez
6 years, 7 months ago (2014-05-14 16:37:01 UTC) #3
Julien - ping for review
lgtm, let's improve the description by mentioning what the new test covers.
6 years, 7 months ago (2014-05-21 16:16:23 UTC) #4
jfernandez
The CQ bit was checked by jfernandez@igalia.com
6 years, 7 months ago (2014-05-22 14:49:57 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jfernandez@igalia.com/278543003/20001
6 years, 7 months ago (2014-05-22 14:51:04 UTC) #6
commit-bot: I haz the power
6 years, 7 months ago (2014-05-23 00:17:53 UTC) #7
Message was sent while issue was closed.
Change committed as 174607

Powered by Google App Engine
This is Rietveld 408576698