Chromium Code Reviews Chromium Code Reviews
Issue 278543003:
New tests case for verifying not sized template-areas use auto-{columns,rows}. (Closed)
Base URL: https://chromium.googlesource.com/chromium/blink.git@master| OLD | NEW |
|---|---|
| 1 <!DOCTYPE HTML> | 1 <!DOCTYPE HTML> |
| 2 <html> | 2 <html> |
| 3 <head> | 3 <head> |
| 4 <link href="resources/grid.css" rel="stylesheet"> | 4 <link href="resources/grid.css" rel="stylesheet"> |
| 5 <style> | 5 <style> |
| 6 .grid { | 6 .grid { |
| 7 grid-template-rows: 20px; | 7 grid-template-rows: 20px; |
| 8 grid-template-columns: 10px; | 8 grid-template-columns: 10px; |
| 9 } | 9 } |
| 10 | 10 |
| 11 .gridAutoFixedFixed { | 11 .gridAutoFixedFixed { |
| 12 grid-auto-rows: 30px; | 12 grid-auto-rows: 30px; |
| 13 grid-auto-columns: 50px; | 13 grid-auto-columns: 50px; |
| 14 } | 14 } |
| 15 | 15 |
| 16 .gridAreas { | |
| 17 grid-template-areas: "first second"; | |
|
Manuel Rego
2014/05/14 15:11:34
I'd define 2 rows too, in order to check that both
| |
| 18 } | |
| 19 | |
| 16 .gridAutoMinMax { | 20 .gridAutoMinMax { |
| 17 height: 1000px; | 21 height: 1000px; |
| 18 grid-auto-rows: minmax(10%, 15px); | 22 grid-auto-rows: minmax(10%, 15px); |
| 19 grid-auto-columns: minmax(30%, 100px); | 23 grid-auto-columns: minmax(30%, 100px); |
| 20 } | 24 } |
| 21 | 25 |
| 22 .gridAutoMinMaxContent { | 26 .gridAutoMinMaxContent { |
| 23 grid-auto-rows: min-content; | 27 grid-auto-rows: min-content; |
| 24 grid-auto-columns: max-content; | 28 grid-auto-columns: max-content; |
| 25 } | 29 } |
| (...skipping 15 matching lines...) Expand all Loading... | |
| 41 <div class="sizedToGridArea secondRowSecondColumn" data-offset-x="10" da ta-offset-y="20" data-expected-width="300" data-expected-height="100">XXXXX XXXX XX</div> | 45 <div class="sizedToGridArea secondRowSecondColumn" data-offset-x="10" da ta-offset-y="20" data-expected-width="300" data-expected-height="100">XXXXX XXXX XX</div> |
| 42 </div> | 46 </div> |
| 43 </div> | 47 </div> |
| 44 | 48 |
| 45 <div class="unconstrainedContainer" style="position: relative"> | 49 <div class="unconstrainedContainer" style="position: relative"> |
| 46 <div class="grid gridAutoMinMaxContent"> | 50 <div class="grid gridAutoMinMaxContent"> |
| 47 <div class="sizedToGridArea secondRowSecondColumn" data-offset-x="10" da ta-offset-y="20" data-expected-width="120" data-expected-height="10">XXXXX XXXXX X</div> | 51 <div class="sizedToGridArea secondRowSecondColumn" data-offset-x="10" da ta-offset-y="20" data-expected-width="120" data-expected-height="10">XXXXX XXXXX X</div> |
| 48 </div> | 52 </div> |
| 49 </div> | 53 </div> |
| 50 | 54 |
| 55 <div class="unconstrainedContainer" style="position: relative"> | |
| 56 <div class="grid gridAutoFixedFixed gridAreas"> | |
| 57 <div style="grid-column: second;" class="sizedToGridArea" data-offset-x= "10" data-offset-y="0" data-expected-width="50" data-expected-height="20">XXXXX XXXXXX</div> | |
|
Manuel Rego
2014/05/14 15:11:34
Here, I'd use "grid-area: placeholder;" instead of
| |
| 58 </div> | |
| 59 </div> | |
| 60 | |
| 51 </body> | 61 </body> |
| 52 </html> | 62 </html> |
| OLD | NEW |
