Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 2785413002: [chromedriver] Introduce chromeOptions.useAutomationExtension. (Closed)

Created:
3 years, 8 months ago by samuong
Modified:
3 years, 3 months ago
Reviewers:
stgao
CC:
chromium-reviews, samuong+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[chromedriver] Introduce chromeOptions.useAutomationExtension. This allows clients to enable or disable the ChromeDriver automation extension. It is currently true by default, but once we introduce DevTools commands to replace the extension, we'll set this to false by default, and later remove it. BUG=604324 TBR=stgao@chromium.org Review-Url: https://codereview.chromium.org/2785413002 Cr-Commit-Position: refs/heads/master@{#461032} Committed: https://chromium.googlesource.com/chromium/src/+/d6cc35e9043b01bfffaf3164bee1c5310cdedcf7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -4 lines) Patch
M chrome/test/chromedriver/capabilities.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/test/chromedriver/capabilities.cc View 2 chunks +4 lines, -1 line 0 comments Download
M chrome/test/chromedriver/chrome_launcher.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/test/chromedriver/test/run_py_tests.py View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2785413002/1
3 years, 8 months ago (2017-03-31 04:04:20 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/d6cc35e9043b01bfffaf3164bee1c5310cdedcf7
3 years, 8 months ago (2017-03-31 04:38:38 UTC) #5
stgao
lgtm
3 years, 8 months ago (2017-03-31 05:06:32 UTC) #6
sakethbansal
3 years, 3 months ago (2017-09-18 10:48:53 UTC) #7
Message was sent while issue was closed.
On 2017/03/31 05:06:32, stgao wrote:
> lgtm

The free version of Chromium browser is available for free on tutuapp. Download
it from http://tutuappvipdownload.com

Powered by Google App Engine
This is Rietveld 408576698