Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(477)

Issue 2785373004: Remove BuildInfo#isGreaterThanN() (Closed)

Created:
3 years, 8 months ago by Theresa
Modified:
3 years, 8 months ago
CC:
agrieve+watch_chromium.org, chromium-reviews, vmpstr+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove BuildInfo#isGreaterThanN() The NMR1 SDK has been published upstream, so BuildInfo#isGreaterThanN is no longer needed. This patch also removes reflection for UserManager#isDemoUser() and ShortcutManager#reportShortcutUsed(), and updates AndroidManifest.xml to remove the conditional include of launchershortcut.xml and network_security_config.xml. BUG=707302 Review-Url: https://codereview.chromium.org/2785373004 Cr-Commit-Position: refs/heads/master@{#461787} Committed: https://chromium.googlesource.com/chromium/src/+/df46c2242e4635dc77fce945bfc0ea0089efee31

Patch Set 1 #

Patch Set 2 : Remove BuildInfo#isGreaterThanN() #

Patch Set 3 : Updates for network security config #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -44 lines) Patch
M base/android/java/src/org/chromium/base/ApiCompatibilityUtils.java View 2 chunks +5 lines, -15 lines 0 comments Download
M base/android/java/src/org/chromium/base/BuildInfo.java View 1 chunk +0 lines, -7 lines 0 comments Download
M build/android/lint/suppressions.xml View 1 2 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/android/BUILD.gn View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/android/java/AndroidManifest.xml View 1 2 2 chunks +0 lines, -4 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java View 4 chunks +6 lines, -12 lines 0 comments Download

Messages

Total messages: 25 (17 generated)
Theresa
tedchoc@ ptal at everything agrieve@ ptal at BUILD.gn
3 years, 8 months ago (2017-03-31 20:28:08 UTC) #4
agrieve
On 2017/03/31 20:28:08, Theresa wrote: > tedchoc@ ptal at everything > > agrieve@ ptal at ...
3 years, 8 months ago (2017-03-31 20:43:07 UTC) #7
Theresa
It looks like monochrome is still building with N so this isn't ready to land ...
3 years, 8 months ago (2017-03-31 21:53:13 UTC) #10
Ted C
lgtm
3 years, 8 months ago (2017-03-31 22:59:48 UTC) #12
mikecase (-- gone --)
trybots got passed compile step. This should be able to land now I think.
3 years, 8 months ago (2017-04-04 02:05:19 UTC) #14
Theresa
On 2017/04/04 02:05:19, mikecase wrote: > trybots got passed compile step. This should be able ...
3 years, 8 months ago (2017-04-04 15:49:46 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2785373004/40001
3 years, 8 months ago (2017-04-04 17:42:42 UTC) #22
commit-bot: I haz the power
3 years, 8 months ago (2017-04-04 18:47:13 UTC) #25
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/df46c2242e4635dc77fce945bfc0...

Powered by Google App Engine
This is Rietveld 408576698