Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 2785373003: Mark content::TestBrowserContext as live in ExtensionsTest before use. (Closed)

Created:
3 years, 8 months ago by sense (YandexTeam)
Modified:
3 years, 8 months ago
Reviewers:
benwells
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Mark content::TestBrowserContext as live in ExtensionsTest before use. This fixes occasional assertions when a test is based on ExtensionsTest and does service requesting before SetUp is called. BUG=707058 R=benwells@chromium.org Review-Url: https://codereview.chromium.org/2785373003 Cr-Commit-Position: refs/heads/master@{#461374} Committed: https://chromium.googlesource.com/chromium/src/+/d41e9b3d5432ec0bf5e5679fc45432e2e178d6f7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M extensions/browser/extensions_test.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
sense (YandexTeam)
3 years, 8 months ago (2017-03-31 12:08:12 UTC) #3
benwells
lgtm
3 years, 8 months ago (2017-04-02 23:20:25 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2785373003/1
3 years, 8 months ago (2017-04-03 04:21:36 UTC) #8
commit-bot: I haz the power
3 years, 8 months ago (2017-04-03 06:00:02 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d41e9b3d5432ec0bf5e5679fc454...

Powered by Google App Engine
This is Rietveld 408576698