Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 2785313002: Increase the range of WasmCompileModuleMicroSeconds histogram. (Closed)

Created:
3 years, 8 months ago by kschimpf
Modified:
3 years, 8 months ago
Reviewers:
bbudge, bradnelson
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

Increase the range of WasmCompileModuleMicroSeconds histogram. Looking at UMA results, we are getting a lot of compilations (over 5%) that are being lumped into the 1 second (plus) maximum entry. To get more visibility into this, this CL lifts the maxiumum to 10 seconds. BUG=chromium:704922 R=bbudge@chromium.org,bradnelson@chromium.org Review-Url: https://codereview.chromium.org/2785313002 Cr-Commit-Position: refs/heads/master@{#44312} Committed: https://chromium.googlesource.com/v8/v8/+/182a216ffc40fec6d772cb33d2b0b018def2c2eb

Patch Set 1 #

Patch Set 2 : Update both asm and wasm counters. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/counters.h View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (11 generated)
kschimpf
Please review. Thanks!
3 years, 8 months ago (2017-03-30 21:39:45 UTC) #5
bbudge
lgtm
3 years, 8 months ago (2017-03-30 22:40:50 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2785313002/20001
3 years, 8 months ago (2017-03-31 15:19:19 UTC) #12
commit-bot: I haz the power
3 years, 8 months ago (2017-03-31 15:20:39 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/182a216ffc40fec6d772cb33d2b0b018def...

Powered by Google App Engine
This is Rietveld 408576698