Reporting: Make DeliveryAgent self-scheduling.

Reporting: Make DeliveryAgent self-scheduling.

Reporting is a spec for delivering out-of-band reports from various
other parts of the browser. See http://wicg.github.io/reporting/ for
the spec, or https://goo.gl/pygX5I for details of the planned
implementation in Chromium.

This makes the existing DeliveryAgent class self-scheduling using the
ReportingObserver interface: when reports are added to the cache, or
periodically while reports are still queued, it automatically runs the
"send reports" algorithm described in the spec.

BUG=704259
Review-Url: https://codereview.chromium.org/2785293003
Cr-Commit-Position: refs/heads/master@{#465663}
Committed: https://chromium.googlesource.com/chromium/src/+/830962ad03b788b02aa7ac6d8dd02f0a38ba6d4b

[Julia Tuttle, 2017-03-31 16:39:57]

The CQ bit was checked by juliatuttle@chromium.org to run a CQ dry run

[Julia Tuttle, 2017-03-31 16:40:25]

juliatuttle@chromium.org changed reviewers:
+ shivanisha@chromium.org

[Julia Tuttle, 2017-03-31 16:40:26]

PTAL, shivanisha.

[Julia Tuttle, 2017-03-31 16:40:35]

Description was changed from

==========
Reporting: Add DeliveryScheduler to trigger DeliveryAgent.

Reporting is a spec for delivering out-of-band reports from various
other parts of the browser. See http://wicg.github.io/reporting/ for
the spec, or https://goo.gl/pygX5I for details of the planned
implementation in Chromium.

This adds a DeliveryScheduler class that currently uses a simple timer
(stored in the ReportingContext so it can be mocked in tests) and the
ReportingObserver interface to ask the DeliveryAgent to send reports on
a periodic basis as long as there are reports in the REportingCache.

BUG=704259
==========

to

==========
Reporting: Add DeliveryScheduler to trigger DeliveryAgent.

Reporting is a spec for delivering out-of-band reports from various
other parts of the browser. See http://wicg.github.io/reporting/ for
the spec, or https://goo.gl/pygX5I for details of the planned
implementation in Chromium.

This adds a DeliveryScheduler class that currently uses a simple timer
(stored in the ReportingContext so it can be mocked in tests) and the
ReportingObserver interface to ask the DeliveryAgent to send reports on
a periodic basis as long as there are reports in the ReportingCache.

BUG=704259
==========

[commit-bot: I haz the power, 2017-03-31 16:40:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-31 16:47:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-31 16:47:35]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Julia Tuttle, 2017-03-31 17:29:08]

Note: I am considering making this a general-purpose "scheduler" class and
having it call all three of the delivery agent, garbage collector, and
serializer. Thoughts?

[Julia Tuttle, 2017-03-31 18:25:51]

Actually, I talked to Randy, and I'm going to build scheduling into the
DeliveryAgent, GarbageCollector, and Serializer, triggered by the Observer
interface, and with the Timer in the Context for mocking purposes.

This CL is obsolete, but I'm keeping it around for my own reference.

[Julia Tuttle, 2017-04-07 21:42:31]

Description was changed from

==========
Reporting: Add DeliveryScheduler to trigger DeliveryAgent.

Reporting is a spec for delivering out-of-band reports from various
other parts of the browser. See http://wicg.github.io/reporting/ for
the spec, or https://goo.gl/pygX5I for details of the planned
implementation in Chromium.

This adds a DeliveryScheduler class that currently uses a simple timer
(stored in the ReportingContext so it can be mocked in tests) and the
ReportingObserver interface to ask the DeliveryAgent to send reports on
a periodic basis as long as there are reports in the ReportingCache.

BUG=704259
==========

to

==========
Reporting: Make DeliveryAgent self-scheduling.

Reporting is a spec for delivering out-of-band reports from various
other parts of the browser. See http://wicg.github.io/reporting/ for
the spec, or https://goo.gl/pygX5I for details of the planned
implementation in Chromium.

This makes the existing DeliveryAgent class self-scheduling using the
ReportingObserver interface: when reports are added to the cache, or
periodically while reports are still queued, it automatically runs the
"send reports" algorithm described in the spec.

BUG=704259
==========

[Julia Tuttle, 2017-04-07 21:48:37]

Okay, this CL is no longer obsolete, but now depends on the ReportingSerializer
CL, since there is important initialization ordering between the two.

[Julia Tuttle, 2017-04-07 21:51:07]

PTAL, shivanisha.

[Julia Tuttle, 2017-04-07 22:36:54]

The CQ bit was checked by juliatuttle@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-07 22:37:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-07 23:46:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-07 23:46:42]

Dry run: This issue passed the CQ dry run.

[Julia Tuttle, 2017-04-12 16:46:29]

The CQ bit was checked by juliatuttle@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-12 16:47:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-12 17:54:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-12 17:54:58]

Dry run: This issue passed the CQ dry run.

[shivanisha, 2017-04-18 14:42:17]

On 2017/04/07 at 21:51:07, juliatuttle wrote:
> PTAL, shivanisha.

lgtm.

[Julia Tuttle, 2017-04-18 17:55:50]

juliatuttle@chromium.org changed reviewers:
+ csharrison@chromium.org

[Julia Tuttle, 2017-04-18 17:56:03]

Thanks shivanisha! PTAL csharrison for committer signoff.

[Charlie Harrison, 2017-04-18 18:03:48]

On 2017/04/18 17:56:03, Julia Tuttle wrote:
> Thanks shivanisha! PTAL csharrison for committer signoff.

RS LGTM

[Julia Tuttle, 2017-04-18 18:20:09]

The CQ bit was checked by juliatuttle@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-18 18:20:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-18 19:33:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-18 19:33:50]

Dry run: This issue passed the CQ dry run.

[Julia Tuttle, 2017-04-19 17:42:31]

The CQ bit was checked by juliatuttle@chromium.org

[Julia Tuttle, 2017-04-19 17:42:32]

The patchset sent to the CQ was uploaded after l-g-t-m from
shivanisha@chromium.org, csharrison@chromium.org
Link to the patchset: https://codereview.chromium.org/2785293003/#ps120001
(title: "rebase")

[commit-bot: I haz the power, 2017-04-19 17:43:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-19 17:50:08]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1492623751653400,
"parent_rev": "eb8e8df2be632be5824072b96b3159bc2dacbab3", "commit_rev":
"830962ad03b788b02aa7ac6d8dd02f0a38ba6d4b"}

[commit-bot: I haz the power, 2017-04-19 17:50:14]

Description was changed from

==========
Reporting: Make DeliveryAgent self-scheduling.

Reporting is a spec for delivering out-of-band reports from various
other parts of the browser. See http://wicg.github.io/reporting/ for
the spec, or https://goo.gl/pygX5I for details of the planned
implementation in Chromium.

This makes the existing DeliveryAgent class self-scheduling using the
ReportingObserver interface: when reports are added to the cache, or
periodically while reports are still queued, it automatically runs the
"send reports" algorithm described in the spec.

BUG=704259
==========

to

==========
Reporting: Make DeliveryAgent self-scheduling.

Reporting is a spec for delivering out-of-band reports from various
other parts of the browser. See http://wicg.github.io/reporting/ for
the spec, or https://goo.gl/pygX5I for details of the planned
implementation in Chromium.

This makes the existing DeliveryAgent class self-scheduling using the
ReportingObserver interface: when reports are added to the cache, or
periodically while reports are still queued, it automatically runs the
"send reports" algorithm described in the spec.

BUG=704259

Review-Url: https://codereview.chromium.org/2785293003
Cr-Commit-Position: refs/heads/master@{#465663}
Committed:
https://chromium.googlesource.com/chromium/src/+/830962ad03b788b02aa7ac6d8dd0...
==========

[commit-bot: I haz the power, 2017-04-19 17:50:16]

Committed patchset #7 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/830962ad03b788b02aa7ac6d8dd0...