[inspector] move console to builtins

src/debug/interface-types.h

Index: src/debug/interface-types.h
diff --git a/src/debug/interface-types.h b/src/debug/interface-types.h
index 82eb2f2abbc12e8dd42f40b2d4d86efc2275744c..7e48afab55e54eeba86bf7284003a8d75973a220 100644
--- a/src/debug/interface-types.h
+++ b/src/debug/interface-types.h
@@ -9,6 +9,7 @@
 #include <string>
 #include <vector>
 
+#include "include/v8.h"
 #include "src/globals.h"
 
 namespace v8 {
@@ -90,6 +91,37 @@ class V8_EXPORT_PRIVATE BreakLocation : public Location {
   BreakLocationType type_;
 };
 
+// v8::FunctionCallbackInfo could be used for getting arguments only. Calling
+// of any other getter will produce a crash.
+class ConsoleDelegate {
+ public:
+  virtual void Debug(const v8::FunctionCallbackInfo<v8::Value>& info) {}

[dgozman, 2017/04/03 20:19:42]

Should we move ConsoleCallArguments here and privately inherit it from
FunctionCallbackInfo?

[kozy, 2017/04/03 22:34:41]

Done.

+  virtual void Error(const v8::FunctionCallbackInfo<v8::Value>& info) {}
+  virtual void Info(const v8::FunctionCallbackInfo<v8::Value>& info) {}
+  virtual void Log(const v8::FunctionCallbackInfo<v8::Value>& info) {}
+  virtual void Warn(const v8::FunctionCallbackInfo<v8::Value>& info) {}
+  virtual void Dir(const v8::FunctionCallbackInfo<v8::Value>& info) {}
+  virtual void DirXml(const v8::FunctionCallbackInfo<v8::Value>& info) {}
+  virtual void Table(const v8::FunctionCallbackInfo<v8::Value>& info) {}
+  virtual void Trace(const v8::FunctionCallbackInfo<v8::Value>& info) {}
+  virtual void Group(const v8::FunctionCallbackInfo<v8::Value>& info) {}
+  virtual void GroupCollapsed(const v8::FunctionCallbackInfo<v8::Value>& info) {
+  }
+  virtual void GroupEnd(const v8::FunctionCallbackInfo<v8::Value>& info) {}
+  virtual void Clear(const v8::FunctionCallbackInfo<v8::Value>& info) {}
+  virtual void Count(const v8::FunctionCallbackInfo<v8::Value>& info) {}
+  virtual void Assert(const v8::FunctionCallbackInfo<v8::Value>& info) {}
+  virtual void MarkTimeline(const v8::FunctionCallbackInfo<v8::Value>& info) {}
+  virtual void Profile(const v8::FunctionCallbackInfo<v8::Value>& info) {}
+  virtual void ProfileEnd(const v8::FunctionCallbackInfo<v8::Value>& info) {}
+  virtual void Timeline(const v8::FunctionCallbackInfo<v8::Value>& info) {}
+  virtual void TimelineEnd(const v8::FunctionCallbackInfo<v8::Value>& info) {}
+  virtual void Time(const v8::FunctionCallbackInfo<v8::Value>& info) {}
+  virtual void TimeEnd(const v8::FunctionCallbackInfo<v8::Value>& info) {}
+  virtual void TimeStamp(const v8::FunctionCallbackInfo<v8::Value>& info) {}
+  virtual ~ConsoleDelegate() = default;
+};
+
 }  // namespace debug
 }  // namespace v8