[inspector] move console to builtins

src/debug/interface-types.h

 // Copyright 2016 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef V8_DEBUG_INTERFACE_TYPES_H_
 #define V8_DEBUG_INTERFACE_TYPES_H_
 
 #include <cstdint>
 #include <string>
 #include <vector>
 
+#include "include/v8.h"
 #include "src/globals.h"
 
 namespace v8 {
 namespace debug {
 
 /**
  * Defines location inside script.
  * Lines and columns are 0-based.
  */
 class V8_EXPORT_PRIVATE Location {
@@ skipping 61 matching lines @@
  public:
   BreakLocation(int line_number, int column_number, BreakLocationType type)
       : Location(line_number, column_number), type_(type) {}
 
   BreakLocationType type() const { return type_; }
 
  private:
   BreakLocationType type_;
 };
 
+// v8::FunctionCallbackInfo could be used for getting arguments only. Calling
+// of any other getter will produce a crash.
+class ConsoleDelegate {
+ public:
+  virtual void Debug(const v8::FunctionCallbackInfo<v8::Value>& info) {}

[dgozman, 2017/04/03 20:19:42]

Should we move ConsoleCallArguments here and privately inherit it from
FunctionCallbackInfo?

[kozy, 2017/04/03 22:34:41]

Done.

+  virtual void Error(const v8::FunctionCallbackInfo<v8::Value>& info) {}
+  virtual void Info(const v8::FunctionCallbackInfo<v8::Value>& info) {}
+  virtual void Log(const v8::FunctionCallbackInfo<v8::Value>& info) {}
+  virtual void Warn(const v8::FunctionCallbackInfo<v8::Value>& info) {}
+  virtual void Dir(const v8::FunctionCallbackInfo<v8::Value>& info) {}
+  virtual void DirXml(const v8::FunctionCallbackInfo<v8::Value>& info) {}
+  virtual void Table(const v8::FunctionCallbackInfo<v8::Value>& info) {}
+  virtual void Trace(const v8::FunctionCallbackInfo<v8::Value>& info) {}
+  virtual void Group(const v8::FunctionCallbackInfo<v8::Value>& info) {}
+  virtual void GroupCollapsed(const v8::FunctionCallbackInfo<v8::Value>& info) {
+  }
+  virtual void GroupEnd(const v8::FunctionCallbackInfo<v8::Value>& info) {}
+  virtual void Clear(const v8::FunctionCallbackInfo<v8::Value>& info) {}
+  virtual void Count(const v8::FunctionCallbackInfo<v8::Value>& info) {}
+  virtual void Assert(const v8::FunctionCallbackInfo<v8::Value>& info) {}
+  virtual void MarkTimeline(const v8::FunctionCallbackInfo<v8::Value>& info) {}
+  virtual void Profile(const v8::FunctionCallbackInfo<v8::Value>& info) {}
+  virtual void ProfileEnd(const v8::FunctionCallbackInfo<v8::Value>& info) {}
+  virtual void Timeline(const v8::FunctionCallbackInfo<v8::Value>& info) {}
+  virtual void TimelineEnd(const v8::FunctionCallbackInfo<v8::Value>& info) {}
+  virtual void Time(const v8::FunctionCallbackInfo<v8::Value>& info) {}
+  virtual void TimeEnd(const v8::FunctionCallbackInfo<v8::Value>& info) {}
+  virtual void TimeStamp(const v8::FunctionCallbackInfo<v8::Value>& info) {}
+  virtual ~ConsoleDelegate() = default;
+};
+
 }  // namespace debug
 }  // namespace v8
 
 #endif  // V8_DEBUG_INTERFACE_TYPES_H_