[Ash] Fold TrayNotificationView into AccessibilityPopupView

[Ash] Fold TrayNotificationView into AccessibilityPopupView

AccessibilityPopupView is now the only subclass of
TrayNotificationView, so fold the latter into the former.
This CL also removes the now-unused PNG asset for
the a11y icon.

BUG=686217, 685845
TEST=manual
TBR=jamescook@chromium.org

Review-Url: https://codereview.chromium.org/2785273002
Cr-Commit-Position: refs/heads/master@{#461512}
Committed: https://chromium.googlesource.com/chromium/src/+/673de101a2b30b905462441b12828a83f85d02d7

[tdanderson, 2017-03-30 19:40:50]

The CQ bit was checked by tdanderson@chromium.org to run a CQ dry run

[tdanderson, 2017-03-30 19:41:50]

tdanderson@chromium.org changed reviewers:
+ estade@chromium.org

[tdanderson, 2017-03-30 19:41:50]

Evan, can you please take a look?

[commit-bot: I haz the power, 2017-03-30 19:42:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-30 22:15:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-30 22:15:34]

Dry run: This issue passed the CQ dry run.

[Evan Stade, 2017-03-31 00:07:24]

lgtm

https://codereview.chromium.org/2785273002/diff/1/ash/common/system/tray_acce...
File ash/common/system/tray_accessibility.h (right):

https://codereview.chromium.org/2785273002/diff/1/ash/common/system/tray_acce...
ash/common/system/tray_accessibility.h:54: void InitView();
nit: might as well just inline the implementation of InitView into the ctor. If
you want to follow the oft-ignored "don't do work in constructors" guidance then
you'd need to call this after the ctor, not in the ctor. (Also I'd call it
simply Init().)

[tdanderson, 2017-04-03 18:24:55]

The CQ bit was checked by tdanderson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-03 18:25:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tdanderson, 2017-04-03 18:25:56]

The CQ bit was unchecked by tdanderson@chromium.org

[tdanderson, 2017-04-03 18:26:29]

Description was changed from

==========
[Ash] Fold TrayNotificationView into AccessibilityPopupView

AccessibilityPopupView is now the only subclass of
TrayNotificationView, so fold the latter into the former.
This CL also removes the now-unused PNG asset for
the a11y icon.

BUG=686217,685845
TEST=manual
==========

to

==========
[Ash] Fold TrayNotificationView into AccessibilityPopupView

AccessibilityPopupView is now the only subclass of
TrayNotificationView, so fold the latter into the former.
This CL also removes the now-unused PNG asset for
the a11y icon.

BUG=686217,685845
TEST=manual
TBR=jamescook@chromium.org
==========

[tdanderson, 2017-04-03 18:26:46]

TBR James for ash/BUILD.gn

https://codereview.chromium.org/2785273002/diff/1/ash/common/system/tray_acce...
File ash/common/system/tray_accessibility.h (right):

https://codereview.chromium.org/2785273002/diff/1/ash/common/system/tray_acce...
ash/common/system/tray_accessibility.h:54: void InitView();
On 2017/03/31 00:07:24, Evan Stade (ooo 3-31) wrote:
> nit: might as well just inline the implementation of InitView into the ctor.
If
> you want to follow the oft-ignored "don't do work in constructors" guidance
then
> you'd need to call this after the ctor, not in the ctor. (Also I'd call it
> simply Init().)

Done.

[tdanderson, 2017-04-03 18:26:53]

The CQ bit was checked by tdanderson@chromium.org

[tdanderson, 2017-04-03 18:26:54]

The patchset sent to the CQ was uploaded after l-g-t-m from estade@chromium.org
Link to the patchset: https://codereview.chromium.org/2785273002/#ps40001
(title: "move work out of ctor")

[commit-bot: I haz the power, 2017-04-03 18:27:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-03 19:58:40]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1491244013938460,
"parent_rev": "afb25842158a4bad4c7e61dfc0b1c48223f9d351", "commit_rev":
"673de101a2b30b905462441b12828a83f85d02d7"}

[commit-bot: I haz the power, 2017-04-03 19:59:28]

Description was changed from

==========
[Ash] Fold TrayNotificationView into AccessibilityPopupView

AccessibilityPopupView is now the only subclass of
TrayNotificationView, so fold the latter into the former.
This CL also removes the now-unused PNG asset for
the a11y icon.

BUG=686217,685845
TEST=manual
TBR=jamescook@chromium.org
==========

to

==========
[Ash] Fold TrayNotificationView into AccessibilityPopupView

AccessibilityPopupView is now the only subclass of
TrayNotificationView, so fold the latter into the former.
This CL also removes the now-unused PNG asset for
the a11y icon.

BUG=686217,685845
TEST=manual
TBR=jamescook@chromium.org

Review-Url: https://codereview.chromium.org/2785273002
Cr-Commit-Position: refs/heads/master@{#461512}
Committed:
https://chromium.googlesource.com/chromium/src/+/673de101a2b30b905462441b1282...
==========

[commit-bot: I haz the power, 2017-04-03 19:59:29]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/673de101a2b30b905462441b1282...