Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issue 2785263003: Clarify the implications of symbol_level = 1 (Closed)

Created:
3 years, 8 months ago by brucedawson
Modified:
3 years, 8 months ago
Reviewers:
scottmg
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Clarify the implications of symbol_level = 1 It is obvious in hindsight that symbol_level = 1 means that functions with internal linkage won't show up in back traces. R=scottmg@chromium.org BUG=706744 Review-Url: https://codereview.chromium.org/2785263003 Cr-Commit-Position: refs/heads/master@{#461218} Committed: https://chromium.googlesource.com/chromium/src/+/de6de9d3f907de08bce627cb096586c65eabc89a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M build/config/compiler/compiler.gni View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 15 (9 generated)
brucedawson
I could change it to "will not appear", but I'm not going to bother testing ...
3 years, 8 months ago (2017-03-30 23:59:23 UTC) #2
scottmg
lgtm
3 years, 8 months ago (2017-03-31 00:04:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2785263003/1
3 years, 8 months ago (2017-03-31 17:00:06 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/340397)
3 years, 8 months ago (2017-03-31 18:45:57 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2785263003/1
3 years, 8 months ago (2017-03-31 19:38:14 UTC) #12
commit-bot: I haz the power
3 years, 8 months ago (2017-03-31 20:50:49 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/de6de9d3f907de08bce627cb0965...

Powered by Google App Engine
This is Rietveld 408576698