Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Issue 2785253002: Reuse executeForTraverseRoot to avoid a manual loop in SelectorQuery::findTraverseRootsAndExecute. (Closed)

Created:
3 years, 8 months ago by esprehn
Modified:
3 years, 8 months ago
Reviewers:
meade_UTC10, dglazkov, rune
CC:
blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Reuse executeForTraverseRoot to avoid a manual loop in SelectorQuery::findTraverseRootsAndExecute. This lets us remove a for loop inside SelectorQuery::findTraverseRootsAndExecute, we can also make executeForTraverseRoot take a reference since only one caller could have passed null before. BUG=703900 Review-Url: https://codereview.chromium.org/2785253002 Cr-Commit-Position: refs/heads/master@{#460880} Committed: https://chromium.googlesource.com/chromium/src/+/9a91d5107bc7f45f238c52466449a9cea12e8493

Patch Set 1 #

Patch Set 2 : header #

Patch Set 3 : woops #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -12 lines) Patch
M third_party/WebKit/Source/core/dom/SelectorQuery.h View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/SelectorQuery.cpp View 1 2 3 chunks +8 lines, -11 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
esprehn
3 years, 8 months ago (2017-03-30 20:26:24 UTC) #4
dglazkov
lgtm
3 years, 8 months ago (2017-03-30 20:53:07 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2785253002/40001
3 years, 8 months ago (2017-03-30 20:56:37 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-03-30 21:19:25 UTC) #12
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/9a91d5107bc7f45f238c52466449...

Powered by Google App Engine
This is Rietveld 408576698