Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(736)

Issue 2785223002: Announce 'adding' accessibility event when adding a homescreen shortcut. (Closed)

Created:
3 years, 8 months ago by Yaron
Modified:
3 years, 8 months ago
Reviewers:
dominickn, gone
CC:
chromium-reviews, agrieve+watch_chromium.org, dfalcantara+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Announce 'adding' accessibility event when adding a homescreen shortcut. Provides indication that the event is actually taking place. BUG=684596 Review-Url: https://codereview.chromium.org/2785223002 Cr-Commit-Position: refs/heads/master@{#461114} Committed: https://chromium.googlesource.com/chromium/src/+/ebf49e00690e8812efa7deeb58fcf0a126ed2687

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/infobar/AppBannerInfoBarAndroid.java View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Yaron
3 years, 8 months ago (2017-03-30 17:09:42 UTC) #2
dominickn
lgtm, thanks! +dfalcantara for OWNERS (this is a noparent directory)
3 years, 8 months ago (2017-03-30 23:48:18 UTC) #4
gone
OWNERS lgtm
3 years, 8 months ago (2017-03-30 23:49:07 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2785223002/1
3 years, 8 months ago (2017-03-31 13:34:15 UTC) #7
commit-bot: I haz the power
3 years, 8 months ago (2017-03-31 14:14:23 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ebf49e00690e8812efa7deeb58fc...

Powered by Google App Engine
This is Rietveld 408576698