Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 2785193003: Enable disabled RenderWidgetHostViewChildFrameTest (Closed)

Created:
3 years, 8 months ago by tzik
Modified:
3 years, 8 months ago
Reviewers:
kinuko
CC:
chromium-reviews, jam, nasko+codewatch_chromium.org, darin-cc_chromium.org, creis+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable disabled RenderWidgetHostViewChildFrameTest These tests should not fail after http://crrev.com/2785883004. BUG=696919 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2785193003 Cr-Commit-Position: refs/heads/master@{#461139} Committed: https://chromium.googlesource.com/chromium/src/+/3e4cfb7160d81365035e927a8a1b63676f718e9e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -14 lines) Patch
M content/browser/frame_host/render_widget_host_view_child_frame_unittest.cc View 2 chunks +2 lines, -14 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 16 (12 generated)
tzik
PTAL
3 years, 8 months ago (2017-03-31 05:39:30 UTC) #6
kinuko
lgtm
3 years, 8 months ago (2017-03-31 05:40:16 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2785193003/1
3 years, 8 months ago (2017-03-31 15:56:06 UTC) #13
commit-bot: I haz the power
3 years, 8 months ago (2017-03-31 16:14:45 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/3e4cfb7160d81365035e927a8a1b...

Powered by Google App Engine
This is Rietveld 408576698