Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(407)

Issue 2785163003: [TTS] Skip expanded state when swiping down v2. (Closed)

Created:
3 years, 8 months ago by Donn Denman
Modified:
3 years, 8 months ago
Reviewers:
mdjones, Theresa
CC:
chromium-reviews, twellington+watch_chromium.org, mdjones+watch_chromium.org, donnd+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[TTS] Skip expanded state when swiping down v2. The approach taken in CL 2780083002 had some minor problems. This reverts that approach and instead checks in getProjectedState whether we're doing the MAXIMIZED==>EXPANDED transition and projects to PEEKED instead. Also reenables testSwipeExpand. BUG=706179 Review-Url: https://codereview.chromium.org/2785163003 Cr-Commit-Position: refs/heads/master@{#461268} Committed: https://chromium.googlesource.com/chromium/src/+/4e3a8e8773e17842197072f1add49917adbaca16

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -20 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPanel.java View 4 chunks +6 lines, -15 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManagerTest.java View 1 chunk +3 lines, -5 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
Donn Denman
Matt, PTAL. Not sure if there was a reason you didn't take this approach before. ...
3 years, 8 months ago (2017-03-30 22:43:01 UTC) #2
mdjones
lgtm
3 years, 8 months ago (2017-03-31 00:19:29 UTC) #3
Donn Denman
Theresa, Matt suggested you take a look too, so PTAL. Thanks!
3 years, 8 months ago (2017-03-31 00:21:10 UTC) #5
Theresa
lgtm
3 years, 8 months ago (2017-03-31 22:20:39 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2785163003/1
3 years, 8 months ago (2017-03-31 22:29:06 UTC) #12
commit-bot: I haz the power
3 years, 8 months ago (2017-03-31 23:21:46 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4e3a8e8773e17842197072f1add4...

Powered by Google App Engine
This is Rietveld 408576698