Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 2785153002: Add protocol APIs to CommandDispatcher. (Closed)

Created:
3 years, 8 months ago by lpromero
Modified:
3 years, 8 months ago
CC:
chromium-reviews, ios-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add protocol APIs to CommandDispatcher. BUG=none R=marq@chromium.org Review-Url: https://codereview.chromium.org/2785153002 Cr-Commit-Position: refs/heads/master@{#461730} Committed: https://chromium.googlesource.com/chromium/src/+/1a91ddcc16f99456e543c79d0406d5f91fdce53d

Patch Set 1 #

Total comments: 8

Patch Set 2 : Feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -2 lines) Patch
M ios/shared/chrome/browser/ui/commands/command_dispatcher.h View 1 1 chunk +10 lines, -0 lines 0 comments Download
M ios/shared/chrome/browser/ui/commands/command_dispatcher.mm View 1 2 chunks +24 lines, -0 lines 0 comments Download
M ios/shared/chrome/browser/ui/commands/command_dispatcher_unittest.mm View 6 chunks +76 lines, -2 lines 0 comments Download

Messages

Total messages: 19 (11 generated)
lpromero
3 years, 8 months ago (2017-03-30 12:49:11 UTC) #1
marq (ping after 24h)
https://codereview.chromium.org/2785153002/diff/1/ios/shared/chrome/browser/ui/commands/command_dispatcher.mm File ios/shared/chrome/browser/ui/commands/command_dispatcher.mm (right): https://codereview.chromium.org/2785153002/diff/1/ios/shared/chrome/browser/ui/commands/command_dispatcher.mm#newcode30 ios/shared/chrome/browser/ui/commands/command_dispatcher.mm:30: unsigned int outCount; Prefer method_count, here and below. https://codereview.chromium.org/2785153002/diff/1/ios/shared/chrome/browser/ui/commands/command_dispatcher.mm#newcode37 ...
3 years, 8 months ago (2017-03-30 14:03:55 UTC) #4
lpromero
https://codereview.chromium.org/2785153002/diff/1/ios/shared/chrome/browser/ui/commands/command_dispatcher.mm File ios/shared/chrome/browser/ui/commands/command_dispatcher.mm (right): https://codereview.chromium.org/2785153002/diff/1/ios/shared/chrome/browser/ui/commands/command_dispatcher.mm#newcode30 ios/shared/chrome/browser/ui/commands/command_dispatcher.mm:30: unsigned int outCount; On 2017/03/30 14:03:55, marq wrote: > ...
3 years, 8 months ago (2017-03-30 15:00:39 UTC) #7
marq (ping after 24h)
https://codereview.chromium.org/2785153002/diff/1/ios/shared/chrome/browser/ui/commands/command_dispatcher.mm File ios/shared/chrome/browser/ui/commands/command_dispatcher.mm (right): https://codereview.chromium.org/2785153002/diff/1/ios/shared/chrome/browser/ui/commands/command_dispatcher.mm#newcode30 ios/shared/chrome/browser/ui/commands/command_dispatcher.mm:30: unsigned int outCount; On 2017/03/30 15:00:39, lpromero wrote: > ...
3 years, 8 months ago (2017-03-31 07:43:02 UTC) #8
lpromero
Updated. Sounds good to see where this will take us. https://codereview.chromium.org/2785153002/diff/1/ios/shared/chrome/browser/ui/commands/command_dispatcher.mm File ios/shared/chrome/browser/ui/commands/command_dispatcher.mm (right): https://codereview.chromium.org/2785153002/diff/1/ios/shared/chrome/browser/ui/commands/command_dispatcher.mm#newcode30 ...
3 years, 8 months ago (2017-04-04 13:08:52 UTC) #11
marq (ping after 24h)
lgtm
3 years, 8 months ago (2017-04-04 13:19:28 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2785153002/20001
3 years, 8 months ago (2017-04-04 15:36:18 UTC) #16
commit-bot: I haz the power
3 years, 8 months ago (2017-04-04 15:42:11 UTC) #19
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/1a91ddcc16f99456e543c79d0406...

Powered by Google App Engine
This is Rietveld 408576698