Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(968)

Issue 2785123004: Oilpan: Add death tests for same thread checks (Closed)

Created:
3 years, 8 months ago by keishi
Modified:
3 years, 8 months ago
Reviewers:
haraken, oilpan-reviews
CC:
chromium-reviews, oilpan-reviews, Mads Ager (chromium), blink-reviews, kinuko+watch, kouhei+heap_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Oilpan: Add death tests for same thread checks This adds the following death tests to check if the same thread checks are working. HeapTest.MemberSameThreadCheck HeapTest.PersistentSameThreadCheck HeapTest.MarkingSameThreadCheck BUG=706666 Review-Url: https://codereview.chromium.org/2785123004 Cr-Commit-Position: refs/heads/master@{#462061} Committed: https://chromium.googlesource.com/chromium/src/+/151cec4bd92241623dfeb93dbde46d7789ff6dde

Patch Set 1 #

Patch Set 2 : fix #

Patch Set 3 : fix #

Patch Set 4 : fix #

Patch Set 5 : fix #

Patch Set 6 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+130 lines, -0 lines) Patch
M third_party/WebKit/Source/platform/heap/HeapTest.cpp View 1 2 3 4 5 1 chunk +130 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (14 generated)
keishi
PTAL
3 years, 8 months ago (2017-04-05 14:02:16 UTC) #12
haraken
LGTM
3 years, 8 months ago (2017-04-05 14:06:59 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2785123004/100001
3 years, 8 months ago (2017-04-05 14:07:57 UTC) #15
commit-bot: I haz the power
3 years, 8 months ago (2017-04-05 14:14:44 UTC) #18
Message was sent while issue was closed.
Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/151cec4bd92241623dfeb93dbde4...

Powered by Google App Engine
This is Rietveld 408576698