Make no-location redirect response to be "opaque redirect" when redirect mode is manual.

Make no-location redirect response to be "opaque redirect" when redirect mode is manual. 

According to the spec, even if location header is not set, we should
treat the redirect response as "opaqueredirect" if the redirect mode
of the fetch request is "manual".

This behavior was changed by this commit on the spec.
https://github.com/whatwg/fetch/commit/3e501f29eceff41eb81c60fb9937e33e23cf5492

BUG=707185
Review-Url: https://codereview.chromium.org/2785123002
Cr-Commit-Position: refs/heads/master@{#464329}
Committed: https://chromium.googlesource.com/chromium/src/+/cb6838f5badc8c2df03f387f4aa726629214179a

[horo, 2017-03-30 08:21:01]

The CQ bit was checked by horo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-30 08:21:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[horo, 2017-03-30 10:42:01]

Description was changed from

==========
support no location redirect response

BUG=
==========

to

==========
Make no-location redirect response to be opaque redirect when redirect mode is
manual. 

According to the spec, even if location header is not set, we should treat the
redirect response as "opaqueredirect" if the redirect mode of the fetch request
is "manual".

This behavior was changed by this commit on the spec.
https://github.com/whatwg/fetch/commit/8d922d9

BUG=
==========

[horo, 2017-03-30 10:42:30]

Description was changed from

==========
Make no-location redirect response to be opaque redirect when redirect mode is
manual. 

According to the spec, even if location header is not set, we should treat the
redirect response as "opaqueredirect" if the redirect mode of the fetch request
is "manual".

This behavior was changed by this commit on the spec.
https://github.com/whatwg/fetch/commit/8d922d9

BUG=
==========

to

==========
Make no-location redirect response to be an opaque redirect when redirect mode
is manual. 

According to the spec, even if location header is not set, we should
treat the redirect response as "opaqueredirect" if the redirect mode
of the fetch request is "manual".

This behavior was changed by this commit on the spec.
https://github.com/whatwg/fetch/commit/8d922d9

BUG=
==========

[horo, 2017-03-30 10:43:04]

Description was changed from

==========
Make no-location redirect response to be an opaque redirect when redirect mode
is manual. 

According to the spec, even if location header is not set, we should
treat the redirect response as "opaqueredirect" if the redirect mode
of the fetch request is "manual".

This behavior was changed by this commit on the spec.
https://github.com/whatwg/fetch/commit/8d922d9

BUG=
==========

to

==========
Make no-location redirect response to be "opaque redirect" when redirect mode is
manual. 

According to the spec, even if location header is not set, we should
treat the redirect response as "opaqueredirect" if the redirect mode
of the fetch request is "manual".

This behavior was changed by this commit on the spec.
https://github.com/whatwg/fetch/commit/8d922d9

BUG=
==========

[horo, 2017-03-30 11:11:29]

Description was changed from

==========
Make no-location redirect response to be "opaque redirect" when redirect mode is
manual. 

According to the spec, even if location header is not set, we should
treat the redirect response as "opaqueredirect" if the redirect mode
of the fetch request is "manual".

This behavior was changed by this commit on the spec.
https://github.com/whatwg/fetch/commit/8d922d9

BUG=
==========

to

==========
Make no-location redirect response to be "opaque redirect" when redirect mode is
manual. 

According to the spec, even if location header is not set, we should
treat the redirect response as "opaqueredirect" if the redirect mode
of the fetch request is "manual".

This behavior was changed by this commit on the spec.
https://github.com/whatwg/fetch/commit/8d922d9178cbcab296ca3b3a76a775949e3a87a8

BUG=
==========

[horo, 2017-03-30 11:17:33]

horo@chromium.org changed reviewers:
+ hiroshige@chromium.org

[horo, 2017-03-30 11:17:34]

hiroshige@
Could you please review this?

[commit-bot: I haz the power, 2017-03-30 11:54:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-30 11:54:51]

Dry run: This issue passed the CQ dry run.

[horo, 2017-04-11 23:45:03]

On 2017/03/30 11:17:34, horo wrote:
> hiroshige@
> Could you please review this?

ping?

[hiroshige, 2017-04-12 00:25:42]

The code looks consistent with the current spec but
https://github.com/whatwg/fetch/commit/8d922d9178cbcab296ca3b3a76a775949e3a87a8
(linked from the CL description) doesn't look to me to change this behavior.

https://codereview.chromium.org/2785123002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/http/tests/fetch/script-tests/fetch.js
(right):

https://codereview.chromium.org/2785123002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/http/tests/fetch/script-tests/fetch.js:253:
redirect_target_url;
nit: just using '/serviceworker/resources/redirect.php?Redirect=noLocation'
might be better because 'noLocation' is not a URL and the name
redirect_target_url might be confusing.

[horo, 2017-04-12 04:44:42]

Description was changed from

==========
Make no-location redirect response to be "opaque redirect" when redirect mode is
manual. 

According to the spec, even if location header is not set, we should
treat the redirect response as "opaqueredirect" if the redirect mode
of the fetch request is "manual".

This behavior was changed by this commit on the spec.
https://github.com/whatwg/fetch/commit/8d922d9178cbcab296ca3b3a76a775949e3a87a8

BUG=
==========

to

==========
Make no-location redirect response to be "opaque redirect" when redirect mode is
manual. 

According to the spec, even if location header is not set, we should
treat the redirect response as "opaqueredirect" if the redirect mode
of the fetch request is "manual".

This behavior was changed by this commit on the spec.
https://github.com/whatwg/fetch/commit/3e501f29eceff41eb81c60fb9937e33e23cf5492

BUG=
==========

[horo, 2017-04-12 04:48:26]

The CQ bit was checked by horo@chromium.org to run a CQ dry run

[horo, 2017-04-12 04:48:39]

Ah, sorry. The url was wrong. This commit changed the behavior.
https://github.com/whatwg/fetch/commit/3e501f29eceff41eb81c60fb9937e33e23cf5492

Updated the cl description.

https://codereview.chromium.org/2785123002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/http/tests/fetch/script-tests/fetch.js
(right):

https://codereview.chromium.org/2785123002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/http/tests/fetch/script-tests/fetch.js:253:
redirect_target_url;
On 2017/04/12 00:25:42, hiroshige wrote:
> nit: just using '/serviceworker/resources/redirect.php?Redirect=noLocation'
> might be better because 'noLocation' is not a URL and the name
> redirect_target_url might be confusing.

Done.

[commit-bot: I haz the power, 2017-04-12 04:48:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-12 06:45:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-12 06:45:58]

Dry run: This issue passed the CQ dry run.

[hiroshige, 2017-04-12 21:45:35]

lgtm. It would be better to set BUG= field if you have any context behind this
CL, but it is optional.

https://codereview.chromium.org/2785123002/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/http/tests/fetch/script-tests/thorough/redirect.js
(right):

https://codereview.chromium.org/2785123002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/fetch/script-tests/thorough/redirect.js:40:
// the browser process as an error.
Perhaps we shouldn't put non-spec-conformant expectation here?

[horo, 2017-04-13 00:03:20]

Thank you

https://codereview.chromium.org/2785123002/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/http/tests/fetch/script-tests/thorough/redirect.js
(right):

https://codereview.chromium.org/2785123002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/fetch/script-tests/thorough/redirect.js:40:
// the browser process as an error.
On 2017/04/12 21:45:35, hiroshige wrote:
> Perhaps we shouldn't put non-spec-conformant expectation here?

Added crbug link

[horo, 2017-04-13 00:03:24]

The CQ bit was checked by horo@chromium.org

[horo, 2017-04-13 00:03:25]

The patchset sent to the CQ was uploaded after l-g-t-m from
hiroshige@chromium.org
Link to the patchset: https://codereview.chromium.org/2785123002/#ps40001
(title: "add link to crbug.com/707185")

[commit-bot: I haz the power, 2017-04-13 00:05:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-13 00:16:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-13 00:16:11]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[horo, 2017-04-13 00:23:12]

horo@chromium.org changed reviewers:
+ nhiroki@chromium.org

[horo, 2017-04-13 00:23:12]

nhiroki@

Could you please review 	content/browser/cache_storage/cache_storage_cache.cc?

[nhiroki, 2017-04-13 03:31:51]

cache storage lgtm

Can you fill in the BUG= line?

Is there a wpt test for this change?

[horo, 2017-04-13 06:16:24]

Description was changed from

==========
Make no-location redirect response to be "opaque redirect" when redirect mode is
manual. 

According to the spec, even if location header is not set, we should
treat the redirect response as "opaqueredirect" if the redirect mode
of the fetch request is "manual".

This behavior was changed by this commit on the spec.
https://github.com/whatwg/fetch/commit/3e501f29eceff41eb81c60fb9937e33e23cf5492

BUG=
==========

to

==========
Make no-location redirect response to be "opaque redirect" when redirect mode is
manual. 

According to the spec, even if location header is not set, we should
treat the redirect response as "opaqueredirect" if the redirect mode
of the fetch request is "manual".

This behavior was changed by this commit on the spec.
https://github.com/whatwg/fetch/commit/3e501f29eceff41eb81c60fb9937e33e23cf5492

BUG=707185
==========

[horo, 2017-04-13 06:18:00]

On 2017/04/13 03:31:51, nhiroki wrote:
> cache storage lgtm
> 
> Can you fill in the BUG= line?

addedb

> 
> Is there a wpt test for this change?

third_party/WebKit/LayoutTests/external/wpt/fetch/api/redirect/redirect-location.js
is the change.

[horo, 2017-04-13 06:18:05]

On 2017/04/13 03:31:51, nhiroki wrote:
> cache storage lgtm
> 
> Can you fill in the BUG= line?

added.

> 
> Is there a wpt test for this change?

third_party/WebKit/LayoutTests/external/wpt/fetch/api/redirect/redirect-location.js
is the change.

[horo, 2017-04-13 06:18:13]

The CQ bit was checked by horo@chromium.org

[commit-bot: I haz the power, 2017-04-13 06:18:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-13 07:27:04]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1492064293936430,
"parent_rev": "30ea9ef0ec1852811e39032244af1939ffb618d5", "commit_rev":
"cb6838f5badc8c2df03f387f4aa726629214179a"}

[commit-bot: I haz the power, 2017-04-13 07:28:31]

Description was changed from

==========
Make no-location redirect response to be "opaque redirect" when redirect mode is
manual. 

According to the spec, even if location header is not set, we should
treat the redirect response as "opaqueredirect" if the redirect mode
of the fetch request is "manual".

This behavior was changed by this commit on the spec.
https://github.com/whatwg/fetch/commit/3e501f29eceff41eb81c60fb9937e33e23cf5492

BUG=707185
==========

to

==========
Make no-location redirect response to be "opaque redirect" when redirect mode is
manual. 

According to the spec, even if location header is not set, we should
treat the redirect response as "opaqueredirect" if the redirect mode
of the fetch request is "manual".

This behavior was changed by this commit on the spec.
https://github.com/whatwg/fetch/commit/3e501f29eceff41eb81c60fb9937e33e23cf5492

BUG=707185

Review-Url: https://codereview.chromium.org/2785123002
Cr-Commit-Position: refs/heads/master@{#464329}
Committed:
https://chromium.googlesource.com/chromium/src/+/cb6838f5badc8c2df03f387f4aa7...
==========

[commit-bot: I haz the power, 2017-04-13 07:28:32]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/cb6838f5badc8c2df03f387f4aa7...