Added available bit to m_selectorIndex.

Added available bit to m_selectorIndex.

Increased the max number of simple selectors for one style from 8192 to
16384 by moving one bit to the second 32-bit part to make space for
another bit. There is one bit left, but it cannot be utilized since the
bit field cannot span two 32 bit values. This doesn't really fix the
issue since it's not unlikely someone will use more than 16000 selectors
if they use more than 8000 selectors.

R=meade@chromium.org
BUG=704562
Review-Url: https://codereview.chromium.org/2785103004
Cr-Commit-Position: refs/heads/master@{#461389}
Committed: https://chromium.googlesource.com/chromium/src/+/bf40056461d01f9e704f7608c5684663ded95abc

[rune, 2017-03-31 07:08:40]

The CQ bit was checked by rune@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2017-03-31 07:08:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[rune, 2017-03-31 07:10:01]

The CQ bit was unchecked by rune@opera.com

[rune, 2017-03-31 12:01:03]

The CQ bit was checked by rune@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2017-03-31 12:01:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[rune, 2017-03-31 12:52:08]

Description was changed from

==========
Added comment with bug refs about RuleData selector index.

R=meade@chromium.org
BUG=704562
==========

to

==========
Added available bit to m_selectorIndex.

Increased the max number of simple selectors for one style from 8192 to
16384 by moving one bit to the second 32-bit part to make space for
another bit. There is one bit left, but it cannot be utilized since the
bit field cannot span two 32 bit values. This doesn't really fix the
issue since it's not unlikely someone will use more than 16000 selectors
if they use more than 8000 selectors.

R=meade@chromium.org
BUG=704562
==========

[commit-bot: I haz the power, 2017-03-31 13:22:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-31 13:22:35]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[rune, 2017-03-31 17:50:31]

The CQ bit was checked by rune@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2017-03-31 17:51:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[rune, 2017-03-31 17:52:34]

ptal

https://codereview.chromium.org/2785103004/diff/40001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/fast/css/selector-list-limits.html (right):

https://codereview.chromium.org/2785103004/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/css/selector-list-limits.html:17: var
selectorLimit = 16384;
This is basically test the same as the unit test I added. Should I just remove
this test? I think a unit test is more suitable for this.

[commit-bot: I haz the power, 2017-03-31 19:28:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-31 19:28:13]

Dry run: This issue passed the CQ dry run.

[meade_UTC10, 2017-04-03 04:11:33]

lgtm

Fun times. Do you know if there's a more permanent solution that can be done?

https://codereview.chromium.org/2785103004/diff/40001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/fast/css/selector-list-limits.html (right):

https://codereview.chromium.org/2785103004/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/css/selector-list-limits.html:17: var
selectorLimit = 16384;
On 2017/03/31 17:52:34, rune wrote:
> This is basically test the same as the unit test I added. Should I just remove
> this test? I think a unit test is more suitable for this.

Yeah it makes sense to remove it, unless there's some cross-platform spec'ed
limit that I don't know about...

[rune, 2017-04-03 07:41:17]

On 2017/04/03 04:11:33, Eddy wrote:
> lgtm
> 
> Fun times. Do you know if there's a more permanent solution that can be done?

Extend the size of RuleData, or come up with a different way to store this which
doesn't increase memory use or makes accessing rules slower.

>
https://codereview.chromium.org/2785103004/diff/40001/third_party/WebKit/Layo...
> File third_party/WebKit/LayoutTests/fast/css/selector-list-limits.html
(right):
> 
>
https://codereview.chromium.org/2785103004/diff/40001/third_party/WebKit/Layo...
> third_party/WebKit/LayoutTests/fast/css/selector-list-limits.html:17: var
> selectorLimit = 16384;
> On 2017/03/31 17:52:34, rune wrote:
> > This is basically test the same as the unit test I added. Should I just
remove
> > this test? I think a unit test is more suitable for this.
> 
> Yeah it makes sense to remove it, unless there's some cross-platform spec'ed
> limit that I don't know about...

Not as far as I know. Haven't found anything in the specs.

[rune, 2017-04-03 07:41:24]

The CQ bit was checked by rune@opera.com

[rune, 2017-04-03 07:41:24]

The patchset sent to the CQ was uploaded after l-g-t-m from meade@chromium.org
Link to the patchset: https://codereview.chromium.org/2785103004/#ps60001
(title: "Prefer unit test.")

[commit-bot: I haz the power, 2017-04-03 07:41:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-03 09:05:53]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1491205284219180,
"parent_rev": "330bfd236aa4574a1ee370d4b369e755c6fe034d", "commit_rev":
"bf40056461d01f9e704f7608c5684663ded95abc"}

[commit-bot: I haz the power, 2017-04-03 09:06:42]

Description was changed from

==========
Added available bit to m_selectorIndex.

Increased the max number of simple selectors for one style from 8192 to
16384 by moving one bit to the second 32-bit part to make space for
another bit. There is one bit left, but it cannot be utilized since the
bit field cannot span two 32 bit values. This doesn't really fix the
issue since it's not unlikely someone will use more than 16000 selectors
if they use more than 8000 selectors.

R=meade@chromium.org
BUG=704562
==========

to

==========
Added available bit to m_selectorIndex.

Increased the max number of simple selectors for one style from 8192 to
16384 by moving one bit to the second 32-bit part to make space for
another bit. There is one bit left, but it cannot be utilized since the
bit field cannot span two 32 bit values. This doesn't really fix the
issue since it's not unlikely someone will use more than 16000 selectors
if they use more than 8000 selectors.

R=meade@chromium.org
BUG=704562

Review-Url: https://codereview.chromium.org/2785103004
Cr-Commit-Position: refs/heads/master@{#461389}
Committed:
https://chromium.googlesource.com/chromium/src/+/bf40056461d01f9e704f7608c568...
==========

[commit-bot: I haz the power, 2017-04-03 09:06:43]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/bf40056461d01f9e704f7608c568...