Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Unified Diff: chrome/test/chromedriver/chrome/chrome_desktop_impl.cc

Issue 2785083002: Use devtools to set user agent in chromedriver (Closed)
Patch Set: Fix New Tab test Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/chromedriver/capabilities_unittest.cc ('k') | chrome/test/chromedriver/chrome/chrome_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/chromedriver/chrome/chrome_desktop_impl.cc
diff --git a/chrome/test/chromedriver/chrome/chrome_desktop_impl.cc b/chrome/test/chromedriver/chrome/chrome_desktop_impl.cc
index c6f843e7248da15778dad9de09bf9199f24a68c2..afc0c144671bac2b6b5371f876866a9ec69a9792 100644
--- a/chrome/test/chromedriver/chrome/chrome_desktop_impl.cc
+++ b/chrome/test/chromedriver/chrome/chrome_desktop_impl.cc
@@ -148,10 +148,10 @@ Status ChromeDesktopImpl::WaitForPageToLoad(
// https://code.google.com/p/chromedriver/issues/detail?id=1205
device_metrics = nullptr;
}
- std::unique_ptr<WebView> web_view_tmp(
- new WebViewImpl(id, w3c_compliant, devtools_http_client_->browser_info(),
- devtools_http_client_->CreateClient(id), device_metrics,
- page_load_strategy()));
+ std::unique_ptr<WebView> web_view_tmp(new WebViewImpl(
+ id, w3c_compliant, devtools_http_client_->browser_info(),
+ devtools_http_client_->CreateClient(id), device_metrics,
+ page_load_strategy(), devtools_http_client_->user_agent()));
Status status = web_view_tmp->ConnectIfNecessary();
if (status.IsError())
return status;
« no previous file with comments | « chrome/test/chromedriver/capabilities_unittest.cc ('k') | chrome/test/chromedriver/chrome/chrome_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698