Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5991)

Unified Diff: chrome/test/chromedriver/capabilities_unittest.cc

Issue 2785083002: Use devtools to set user agent in chromedriver (Closed)
Patch Set: Fix New Tab test Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/chromedriver/capabilities.cc ('k') | chrome/test/chromedriver/chrome/chrome_desktop_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/chromedriver/capabilities_unittest.cc
diff --git a/chrome/test/chromedriver/capabilities_unittest.cc b/chrome/test/chromedriver/capabilities_unittest.cc
index a1a3e7ff248f9aa6e8ffa9783bb0d0421b830912..2887616924eee1a4f19ae955b7887318df2edc24 100644
--- a/chrome/test/chromedriver/capabilities_unittest.cc
+++ b/chrome/test/chromedriver/capabilities_unittest.cc
@@ -477,9 +477,7 @@ TEST(ParseCapabilities, MobileEmulationUserAgent) {
Status status = capabilities.Parse(caps);
ASSERT_TRUE(status.IsOk());
- ASSERT_EQ(1u, capabilities.switches.GetSize());
- ASSERT_TRUE(capabilities.switches.HasSwitch("user-agent"));
- ASSERT_EQ("Agent Smith", capabilities.switches.GetSwitchValue("user-agent"));
+ ASSERT_EQ("Agent Smith", capabilities.user_agent);
}
TEST(ParseCapabilities, MobileEmulationDeviceMetrics) {
@@ -507,13 +505,11 @@ TEST(ParseCapabilities, MobileEmulationDeviceName) {
Status status = capabilities.Parse(caps);
ASSERT_TRUE(status.IsOk());
- ASSERT_EQ(1u, capabilities.switches.GetSize());
- ASSERT_TRUE(capabilities.switches.HasSwitch("user-agent"));
ASSERT_EQ(
"Mozilla/5.0 (Linux; Android 4.4.4; Nexus 5 Build/KTU84P) "
"AppleWebKit/537.36 (KHTML, like Gecko) Chrome/38.0.2125.114 Mobile "
"Safari/537.36",
- capabilities.switches.GetSwitchValue("user-agent"));
+ capabilities.user_agent);
ASSERT_EQ(360, capabilities.device_metrics->width);
ASSERT_EQ(640, capabilities.device_metrics->height);
« no previous file with comments | « chrome/test/chromedriver/capabilities.cc ('k') | chrome/test/chromedriver/chrome/chrome_desktop_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698