Make browsing context keywords case-insensitive.

Make browsing context keywords case-insensitive.

The patch makes the browsing context keywords (_blank, _self, _parent,
_top) case-insensitive as is specified in [1]. The patch ensures that
all the tests in [2] pass.

[1] - https://html.spec.whatwg.org/#browsing-context-names
[2] - wpt/html/browsers/windows/browsing-context-names/

BUG=702178
Review-Url: https://codereview.chromium.org/2785063002
Cr-Commit-Position: refs/heads/master@{#461034}
Committed: https://chromium.googlesource.com/chromium/src/+/c631cd11f112484251cf04ae4845cc747b5c1aaf

[MartinRogalla, 2017-03-30 05:50:10]

martin@martinrogalla.com changed reviewers:
+ tkent@chromium.org

[tkent, 2017-03-30 05:57:00]

https://codereview.chromium.org/2785063002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp (right):

https://codereview.chromium.org/2785063002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp:1590: if
(equalIgnoringCase(frameName, "_top")) {
Please use equalIgnoringASCIICase(). equalIgnoringCase() is not for ASCII
case-insensitive.

[MartinRogalla, 2017-03-30 13:19:03]

On 2017/03/30 05:57:00, tkent wrote:
>
https://codereview.chromium.org/2785063002/diff/1/third_party/WebKit/Source/c...
> File third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp (right):
> 
>
https://codereview.chromium.org/2785063002/diff/1/third_party/WebKit/Source/c...
> third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp:1590: if
> (equalIgnoringCase(frameName, "_top")) {
> Please use equalIgnoringASCIICase(). equalIgnoringCase() is not for ASCII
> case-insensitive.

Thanks, now equalIgnoringASCIICase() is used to perform the (in)equality checks.

[tkent, 2017-03-30 15:46:04]

The CQ bit was checked by tkent@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-30 15:46:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-30 16:18:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-30 16:18:48]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[tkent, 2017-03-30 22:24:39]

The CQ bit was checked by tkent@chromium.org

[tkent, 2017-03-30 22:24:39]

lgtm

[commit-bot: I haz the power, 2017-03-30 22:25:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-30 22:38:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-30 22:38:21]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[tkent, 2017-03-30 22:57:27]

Please rebase.  There is a conflict in TestExpectations.

[MartinRogalla, 2017-03-31 01:03:58]

On 2017/03/30 22:57:27, tkent wrote:
> Please rebase.  There is a conflict in TestExpectations.

Okay, should be resolved now.

[MartinRogalla, 2017-03-31 01:04:15]

The CQ bit was checked by martin@martinrogalla.com

[MartinRogalla, 2017-03-31 01:04:16]

The patchset sent to the CQ was uploaded after l-g-t-m from tkent@chromium.org
Link to the patchset: https://codereview.chromium.org/2785063002/#ps40001
(title: "Rebased")

[commit-bot: I haz the power, 2017-03-31 01:05:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-31 04:41:17]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1490922255712860,
"parent_rev": "ab6d23d22c9b28c9ca9b7568db2091db6b70c090", "commit_rev":
"c631cd11f112484251cf04ae4845cc747b5c1aaf"}

[commit-bot: I haz the power, 2017-03-31 04:42:04]

Description was changed from

==========
Make browsing context keywords case-insensitive.

The patch makes the browsing context keywords (_blank, _self, _parent,
_top) case-insensitive as is specified in [1]. The patch ensures that
all the tests in [2] pass.

[1] - https://html.spec.whatwg.org/#browsing-context-names
[2] - wpt/html/browsers/windows/browsing-context-names/

BUG=702178
==========

to

==========
Make browsing context keywords case-insensitive.

The patch makes the browsing context keywords (_blank, _self, _parent,
_top) case-insensitive as is specified in [1]. The patch ensures that
all the tests in [2] pass.

[1] - https://html.spec.whatwg.org/#browsing-context-names
[2] - wpt/html/browsers/windows/browsing-context-names/

BUG=702178

Review-Url: https://codereview.chromium.org/2785063002
Cr-Commit-Position: refs/heads/master@{#461034}
Committed:
https://chromium.googlesource.com/chromium/src/+/c631cd11f112484251cf04ae4845...
==========

[commit-bot: I haz the power, 2017-03-31 04:42:06]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/c631cd11f112484251cf04ae4845...