Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1185)

Issue 2785053003: Default state for the favicon view (Closed)

Created:
3 years, 8 months ago by gambard
Modified:
3 years, 8 months ago
Reviewers:
sdefresne
CC:
chromium-reviews, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, marq+watch_chromium.org, stkhapugin, sdefresne+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Default state for the favicon view This CL allows the favicon view to be configured with nil attributes, creating a default background. BUG=706427 Review-Url: https://codereview.chromium.org/2785053003 Cr-Commit-Position: refs/heads/master@{#461407} Committed: https://chromium.googlesource.com/chromium/src/+/c0b79d75dc0b349a3ae2d9faf74e4f5d8584e844

Patch Set 1 #

Patch Set 2 : Fix indentation #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -6 lines) Patch
M ios/chrome/browser/ui/favicon/favicon_view.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ios/chrome/browser/ui/favicon/favicon_view.mm View 3 chunks +13 lines, -1 line 0 comments Download
M ios/chrome/browser/ui/reading_list/reading_list_collection_view_item.mm View 1 2 2 chunks +2 lines, -3 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 13 (7 generated)
gambard
PTAL.
3 years, 8 months ago (2017-03-30 07:37:57 UTC) #2
sdefresne
lgtm
3 years, 8 months ago (2017-03-30 12:24:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2785053003/20001
3 years, 8 months ago (2017-04-03 11:10:43 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-clang/builds/67696) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, ...
3 years, 8 months ago (2017-04-03 11:13:13 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2785053003/40001
3 years, 8 months ago (2017-04-03 11:18:25 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-04-03 11:29:51 UTC) #13
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/c0b79d75dc0b349a3ae2d9faf74e...

Powered by Google App Engine
This is Rietveld 408576698