DescriptionIncrease the stack size to 2MB for x64 Windows
This patch increases the stack size to 2MB for x64 Windows to reduce
stack overflow crashes.
jgruber@ commented in crbug.com/704536#c25 that V8 build has this
change. This patch uses the same value as V8.
On other platforms, as far as GetDefaultThreadStackSize() tells:
* macOS normally uses 8MB.
* Linux normally uses 8 or 16MB.
* Android uses 2MB.
Assuming comments there are correct, this change should make Windows
closer to other platforms.
Tested by "dumpbin /headers" to locally built chrome.exe:
100000 size of stack reserve
changes to:
200000 size of stack reserve
Both numbers are in hexadecimal.
BUG=704536
Review-Url: https://codereview.chromium.org/2785043002
Cr-Commit-Position: refs/heads/master@{#460828}
Committed: https://chromium.googlesource.com/chromium/src/+/bc85b8b89d33b7a7b8da86268fc30ba4fac70c87
Patch Set 1 #
Messages
Total messages: 16 (11 generated)
|